Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[List/List Item] Mitigate action access when toggling the disabled state #7335

Closed
2 of 3 tasks
geospatialem opened this issue Jul 18, 2023 · 4 comments
Closed
2 of 3 tasks

[List/List Item] Mitigate action access when toggling the disabled state #7335

geospatialem opened this issue Jul 18, 2023 · 4 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Milestone
2023 October Prio...

Comments

@geospatialem
Copy link
Member

Check existing issues

Summary

Ensure all List Items and their actions are available to users when toggling the disabled states.

a11y-listitem-disabled-actions

Actual Behavior

When List Items disabled state is toggled, its actions remain inaccessible to keyboard users, while available to mouse users.

Expected Behavior

Either no tabindex should be present via the interactive helper, or the tabindex should be updated when changing between the disabled state. Additional context provided via Matt addressed in #7254.

Reproduction Sample

https://codepen.io/geospatialem/pen/XWyzpXX

Reproduction Steps

  1. Open the sample
  2. Select the first item in the list by pressing the Enter key
  3. Press the Enter key again to remove any disabled List items
  4. Press Tab to navigate to the apple's action
  5. Press Tab again and observe the next item is the mango's action

Reproduction Version

1.5.0-next.17

Working W3C Example/Tutorial

No response

Relevant Info

#7254 (comment)

Regression?

N/A

Priority impact

p2 - want for current milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react

Esri team

Calcite (dev)
@geospatialem geospatialem added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. a11y Issues related to Accessibility fixes or improvements. p - high Issue should be addressed in the current milestone, impacts component or core functionality 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jul 18, 2023
@github-actions github-actions bot added Calcite (dev) Issues logged by Calcite developers. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone calcite-components Issues specific to the @esri/calcite-components package. labels Jul 18, 2023
@geospatialem geospatialem mentioned this issue Jul 18, 2023
Closed
3 tasks
@geospatialem geospatialem added the research Issues that require more in-depth research or multiple team members to resolve or make decision. label Aug 7, 2023
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Aug 7, 2023
@geospatialem
Copy link
Member Author

Research needed to determine estimate and priority for future implementation. Pertains to the disabled helper/utility.

@geospatialem geospatialem added spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. and removed research Issues that require more in-depth research or multiple team members to resolve or make decision. labels Oct 4, 2023
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Oct 23, 2023
@jcfranco
Copy link
Member

Found out the culprit. The item's host focus behavior is being set as managed, but the item's tabindex is not being set by the parent (e.g., pick/value list-item's tabindex is managed by its parent list). This should be a low-effort fix and feasible for this milestone. I'll also update updateHostInteraction's doc to give context on its hostIsTabbable argument).

@jcfranco jcfranco mentioned this issue Oct 23, 2023
Merged
jcfranco added a commit that referenced this issue Oct 24, 2023
@jcfranco
fix(list-item): restore tabbability when an item's disabled prop is t…
c970603 
…oggled (#8042)

**Related Issue:** #7335 

## Summary

Drop "managed" as the `hostIsTabbable ` argument since the parent does
not control its tabbability (`tabindex`).

This also adds info to `updateHostInteraction`'s doc.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. labels Oct 24, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added the estimate - 3 A day or two of work, likely requires updates to tests. label Oct 25, 2023
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Oct 25, 2023
@geospatialem
Copy link
Member Author

Verified in 1.10.0-next.7 with https://codepen.io/geospatialem/pen/XWyzpXX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Milestone
2023 October Priorities - Maintenance...
Development

No branches or pull requests
2 participants
@jcfranco @geospatialem