Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Combobox] Append custom values to top of Combobox dropdown, not bottom #7288

Closed
2 of 3 tasks
macandcheese opened this issue Jul 6, 2023 · 4 comments
Closed
2 of 3 tasks

[Combobox] Append custom values to top of Combobox dropdown, not bottom #7288

macandcheese opened this issue Jul 6, 2023 · 4 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. c-combobox Issues that pertain to the calcite-combobox and related components Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible.
Milestone
2024-07-31 - Jul ...

Comments

@macandcheese
Copy link
Contributor

macandcheese commented Jul 6, 2023 •
edited by jcfranco
Loading

Check existing issues

Description

Currently, when allow-custom-values is true and a user adds a custom value, it is appended to the bottom of the Combobox dropdown.

This can be confusing, as when presented alongside groups, it's not clear if the added value is part of the last group due to indentation:

Screen Shot 2023-07-06 at 11 12 58 AM

Acceptance Criteria

The appended items are added to the top

Relevant Info

There are probably additional desirable configurations - sometimes an app may want to add a created item to a specific group, or allow a user to remove an item they've created.

cc @ashetland @mitc7862

Which Component

Combobox

Example Use Case

No response

Priority impact

p4 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react

Esri team

Calcite (design)
@macandcheese macandcheese added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jul 6, 2023
@github-actions github-actions bot added impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. labels Jul 6, 2023
@ashetland ashetland added the c-combobox Issues that pertain to the calcite-combobox and related components label Jul 6, 2023
@geospatialem geospatialem added the ready for dev Issues ready for development implementation. label Jul 6, 2023
@github-actions github-actions bot added the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jul 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

cc @geospatialem, @brittneytewks

@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library and removed needs triage Planning workflow - pending design/dev review. labels Jul 6, 2023
@geospatialem geospatialem added the design Issues that need design consultation prior to development. label Sep 6, 2023
@geospatialem geospatialem added this to the 2023 December Priorities milestone Sep 6, 2023
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Sep 6, 2023
@brittneytewks brittneytewks added the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Sep 12, 2023
@brittneytewks brittneytewks removed the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Dec 11, 2023
@aPreciado88 aPreciado88 self-assigned this Jul 16, 2024
@aPreciado88 aPreciado88 added 1 - assigned Issues that are assigned to a sprint and a team member. 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. 1 - assigned Issues that are assigned to a sprint and a team member. labels Jul 16, 2024
@aPreciado88
Copy link
Contributor

After discussing with @macandcheese @ashetland, a couple of things to consider came up, these can be worked on in future issues.

  1. Should there be a dividing line beneath custom values?
  2. Should there be a way to add a group label (optionally) to the appended values?

cc @jcfranco

@aPreciado88 aPreciado88 added the estimate - 2 Small fix or update, may require updates to tests. label Jul 19, 2024
@aPreciado88 aPreciado88 mentioned this issue Jul 19, 2024
Merged
aPreciado88 added a commit that referenced this issue Jul 23, 2024
@aPreciado88
feat(combobox): append custom values to top of dropdown (#9817)
287448b 
**Related Issue:**
[#7288](#7288)

## Summary
Update `combobox` to append custom values to top of dropdown list.
@aPreciado88 aPreciado88 added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jul 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned aPreciado88 Jul 23, 2024
@DitwanP
Copy link
Contributor

DitwanP commented Jul 24, 2024

🍡 Verified on 2.11.0-next.21

@DitwanP DitwanP closed this as completed Jul 24, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jul 24, 2024
@geospatialem geospatialem added the visual changes Issues with visual changes that are added for consistency, but are not backwards compatible. label Jul 25, 2024
calcite-admin pushed a commit that referenced this issue Jul 30, 2024
@aPreciado88 @github-actions
feat(combobox): append custom values to top of dropdown (#9817)
bd55097 
**Related Issue:**
[#7288](#7288)

## Summary
Update `combobox` to append custom values to top of dropdown list.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. c-combobox Issues that pertain to the calcite-combobox and related components Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible.
Projects
None yet
Milestone
2024-07-31 - Jul Release
Development

No branches or pull requests
6 participants
@macandcheese @geospatialem @DitwanP @ashetland @brittneytewks @aPreciado88