Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calcite-popover does not open in a specific case with calcite-tooltip #7158

Closed
jmanke opened this issue Jun 8, 2023 · 5 comments
Closed

calcite-popover does not open in a specific case with calcite-tooltip #7158

jmanke opened this issue Jun 8, 2023 · 5 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Dashboards Issues logged by ArcGIS Dashboards team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 3 A day or two of work, likely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2023 June patch p...

Comments

@jmanke
Copy link

jmanke commented Jun 8, 2023

Actual Behavior

When a calcite-action (element type may not be important) is the target of both a calcite-popover and calcite-tooltip, the calcite-popover will not open if the calcite-tooltip is in the process of appearing. For example, the user hovers over the calcite-action and the tooltip starts to appear - at this exact time, clicking on the action will not open the calcite-popover. The user will need to click the calcite-action two more times for the calcite-popover to appear.

Expected Behavior

The calcite-popover should appear when the user clicks its target.

Reproduction Sample

https://codepen.io/jmanke/pen/ExOabVd?editors=1011

Reproduction Steps

The following repro steps are for this codepen:

  1. Ensure page is refreshed
  2. Hover over action with mouse. Right as the tooltip appears, click on the action. This step is difficult to time just right.
  3. Observe that the popover does not open. It requires clicking on the action two more time to open it.

Reproduction Version

v1.4.2

Relevant Info

Tested on Chrome v114 on MacOS Ventura 13.4

Regression?

No response

Priority impact

p3 - want for upcoming milestone

Impact

Medium - it feels like the popover is broken for some users in this particular workflow.

Esri team

ArcGIS Dashboards
@jmanke jmanke added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Jun 8, 2023
@github-actions github-actions bot added p3 - want for upcoming milestone ArcGIS Dashboards Issues logged by ArcGIS Dashboards team members. labels Jun 8, 2023
@driskull
Copy link
Member

It seems to have to do with debouncing the reposition() method internally. If you resize the page when it gets into one of those bad states it seems to bring the component up to date because it calls reposition again.

@jmanke does this only happen when there is both a tooltip and popover or can you reproduce with just a popover?

@driskull driskull self-assigned this Jun 13, 2023
@driskull driskull added this to the 2023 June patch priorities milestone Jun 13, 2023
@driskull driskull added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Jun 13, 2023
driskull added a commit that referenced this issue Jun 14, 2023
@driskull
fix(combobox, dropdown, input-date-picker, input-time-picker, popover…
e179011 
…, tooltip): Prevent repositioning from affecting other floating components. #7158
@driskull driskull mentioned this issue Jun 14, 2023
Merged
@driskull driskull added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jun 14, 2023
@jmanke
Copy link
Author

jmanke commented Jun 15, 2023

@driskull I can't seem to repro the issue when I remove the tooltip. It may be a timing issue on my end, but I've tried ~50 times and couldn't repro the bug. The only way I've been able to repro is with the steps above.

@driskull
Copy link
Member

Thanks Jeff, those findings make sense. 👍

I think we know the issue and will get it fixed.

jcfranco added a commit that referenced this issue Jun 23, 2023
@driskull @jcfranco
fix(combobox, dropdown, input-date-picker, input-time-picker, popover…
1b02dae 
…, tooltip): Prevent repositioning from affecting other floating components (#7178)

**Related Issue:** #7158

## Summary

This prevent repositioning from affecting other floating components
caused by using a shared, debounced reposition function.

Additionally, this will cancel any in-progress debounced calls if the
component is disconnected.

---------

Co-authored-by: JC Franco <jfranco@esri.com>
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. needs triage Planning workflow - pending design/dev review. labels Jun 23, 2023
@github-actions github-actions bot assigned geospatialem and unassigned driskull Jun 23, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@jcfranco jcfranco added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. labels Jun 23, 2023
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jun 26, 2023
@geospatialem
Copy link
Member

Verified in 1.5.0-next.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Dashboards Issues logged by ArcGIS Dashboards team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 3 A day or two of work, likely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2023 June patch priorities
Development

No branches or pull requests
4 participants
@jcfranco @driskull @geospatialem @jmanke