-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
calcite-list - initial empty list with loading=true is not visually tall enough to show loading animation #7147
Comments
Also appears a bit cut off when only one |
@SkyeSeitz @ashetland What would you folks recommend when the list is empty to display the loading spinner? We'd like to tackle this one for the June priorities this month. |
FYI: I updated my codepen with the workaround I'm using in my apps. I basically unset/reset the 'position' style property of the internal container. |
Yes, that is super doable. |
I think it would be better if the |
Love that idea. Since Loader has scales I wasn't sure if we were trying to be consistent with using a Would we still need to define a minimum height if there are no Items in the List while it's loading? We could go the height of a single List Item, like in your example. |
And assuming List gets small and large scales added to it eventually, we'd probably need to ensure enough height at small scale for the small scale Loader inside Scrim. |
@alisonailea @ashetland if we define heights in which the loading spinner switches from "m" to "s" or "l" do we need these heights defined in the design tokens somewhere? If not, could you give me height number breakpoints for when these size switches should occur? |
**Related Issue:** #7147 ## Summary - Updates the scrim to set the scale of the internal loading spinner based on the scrim size. - Scrim is now responsive with a resize observer. - Breakpoints added based on design. These could maybe go into some kind of component token in the future. - Breakpoint is based on the minimum value of width or height. - Adds test
Installed and assigned for verification. |
Verified with https://codepen.io/geospatialem/pen/MWzWmzQ in |
Actual Behavior
When an empty calcite-list with loading=true is initially displayed it's not visually tall enough to show loading animation.
Expected Behavior
I would expect the calcite-list to be tall enough to display the loading animation even if the list is empty
Reproduction Sample
https://codepen.io/john-grayson/pen/gOQOmZE
Reproduction Steps
Reproduction Version
1.4.2
Relevant Info
No response
Regression?
No response
Priority impact
p4 - not time sensitive
Impact
No response
Esri team
N/A
The text was updated successfully, but these errors were encountered: