Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calcite-navigation-logo: allow slot/property for icon instead of image #7124

Closed
jgrayson-apl opened this issue Jun 5, 2023 · 4 comments
Closed

calcite-navigation-logo: allow slot/property for icon instead of image #7124

jgrayson-apl opened this issue Jun 5, 2023 · 4 comments
Assignees
@geospatialem @SkyeSeitz @ashetland @brittneytewks
Labels
4 - verified Issues that have been released and confirmed resolved. enhancement Issues tied to a new feature or request. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive
Milestone
2023 October Prio...

Comments

@jgrayson-apl
Copy link

Description

For the new calcite-navigation-logo, please provide a slot/property for an icon instead of image as most of the time we don't have an application specific image and use a simple icon instead.

Acceptance Criteria

We need the ability to use an icon instead of a in image

Relevant Info

No response

Which Component

calcite-navigation-logo

Example Use Case

No response

Priority impact

p4 - not time sensitive

Esri team

N/A
@jgrayson-apl jgrayson-apl added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Jun 5, 2023
@github-actions github-actions bot added the impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive label Jun 5, 2023
@jgrayson-apl
Copy link
Author

FYI: found a workaround by adding a do-nothing calcite-action to the 'navigation-action' slot of the calcite-navigation. Not ideal as we don't have the direct ability to disable pointer interactions and calcite-icon won't align correctly... but ok for now.

@macandcheese macandcheese mentioned this issue Jun 5, 2023
Closed
6 tasks
@macandcheese
Copy link
Contributor

Thanks @jgrayson-apl - this makes sense and was something we had considered but didn't add to the first iteration.

@macandcheese macandcheese self-assigned this Jun 28, 2023
@macandcheese macandcheese added 2 - in development Issues that are actively being worked on. figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists and removed 0 - new New issues that need assignment. labels Oct 25, 2023
@macandcheese macandcheese mentioned this issue Oct 25, 2023
Merged
macandcheese added a commit that referenced this issue Oct 25, 2023
@macandcheese
feat(navigation-logo): Adds icon and iconFlipRtl properties (#8054)
049056d 
**Related Issue:** #7124 

## Summary
Adds `icon` and `iconFlipRtl` properties to `calcite-navigation-logo`.
Because `calcite-navigation` and related components are offered in one
scale, this unique `icon` case will use `scale="l"` due to the
prominence and usage of the component, and to ensure `icon` adjacent to
`thumbnail` are presented at equal sizes:

<img width="558" alt="Screenshot 2023-10-25 at 12 18 31 PM"
src="https://github.com/Esri/calcite-design-system/assets/4733155/fa49bc25-c5b1-4051-82b5-785ced404f17">
@macandcheese macandcheese added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Oct 25, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. needs triage Planning workflow - pending design/dev review. labels Oct 26, 2023
@geospatialem
Copy link
Member

Verified in 1.10.0-next.8, also for rtl, with the following:

<calcite-shell>
  <calcite-navigation slot="header">
    <calcite-navigation-logo heading="Whale sightings" icon="globe" description="2023 data observations" slot="logo">
    </calcite-navigation-logo>
  </calcite-navigation>
</calcite-shell>

@SkyeSeitz SkyeSeitz removed the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@SkyeSeitz SkyeSeitz

@ashetland ashetland

@brittneytewks brittneytewks

Labels
4 - verified Issues that have been released and confirmed resolved. enhancement Issues tied to a new feature or request. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive
Projects
None yet
Milestone
2023 October Priorities - Maintenance...
Development

No branches or pull requests
6 participants
@macandcheese @geospatialem @jgrayson-apl @SkyeSeitz @ashetland @brittneytewks