Disabled buttons are clickable in Firefox

[mpayson]

Actual Behavior

Clicking a disabled button fires the onClick event

Expected Behavior

Clicking a disabled button does not fire the onClick event

Reproduction Sample

https://codepen.io/mpayson/pen/VwENeyv

Reproduction Steps

1. Open sample & developer console
2. Click button
3. See logged message

Reproduction Version

1.4.0

Relevant Info

No response

Regression?

No response

Priority impact

p2 - want for current milestone

Impact

Maybe this could be lower priority, we can work around it by ignoring the click even when the button is disabled

Esri team

N/A

[geospatialem]

Was able to repro in FF (Chrome and Edge are performing as-expected). Still repro in last night's 1.4.1 release, which included #7031.

[tristan-morrison]

If it matters for prioritization purposes, this impacts the Editor widget in the JS SDK.

[geospatialem]

There are two workarounds available, however it will prevent providing a tooltip to a disabled button:

<calcite-button style="pointer-events:none" disabled id="example-button">Open modal</calcite-button>

or checking if the button is disabled in the event listener:

button.addEventListener("click", (evt) => {
  if (evt.target.disabled) {
    return;
  } else {
   modal.open = true;
  }
});

[github-actions]

Installed and assigned for verification.

[jcfranco]

@geospatialem Here's a codepen I used to look for regressions related to #5318. Sharing in case it helps.

[geospatialem]

Verified with Franco's codepen above and https://codepen.io/geospatialem/pen/rNQMPXg in 1.5.0-next.4.