Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calcite numeric input deleting decimal point #7039

Closed
nid13240 opened this issue May 26, 2023 · 2 comments
Closed

Calcite numeric input deleting decimal point #7039

nid13240 opened this issue May 26, 2023 · 2 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 5 A few days of work, definitely requires updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality
Milestone
2023 July Priorities

Comments

@nid13240
Copy link

Actual Behavior

When I am editing a decimal value on the calcite input component, the decimal point itself gets deleted when I delete the number in the tenths position. For example, if I have 1.5 and want to change it to 1.8, on trying to delete 5, it would also remove the "." and I would end up typing 18.

Expected Behavior

I expect the decimal position to stay in the input box like it does in the native input element.

Reproduction Sample

https://codepen.io/geospatialem/pen/poxYOdO

Reproduction Steps

Using the codepen above, try to use backspace on the three different input boxes and observe the difference in behavior between calcite-input and native input.

Reproduction Version

1.4.0

Relevant Info

No response

Regression?

No response

Priority impact

p3 - want for upcoming milestone

Impact

No response

Esri team

ArcGIS Map Viewer
@nid13240 nid13240 added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels May 26, 2023
@github-actions github-actions bot added p3 - want for upcoming milestone ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. labels May 26, 2023
@geospatialem geospatialem added estimate - 5 A few days of work, definitely requires updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality and removed needs triage Planning workflow - pending design/dev review. labels Jun 1, 2023
This was referenced Jun 1, 2023
Closed
Closed
@anveshmekala anveshmekala self-assigned this Jun 8, 2023
@benelan benelan added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Jun 8, 2023
@anveshmekala anveshmekala mentioned this issue Jun 8, 2023
Merged
anveshmekala added a commit that referenced this issue Jun 29, 2023
@anveshmekala
fix(input, input-number): no longer removes trailing decimal separator (
01535cf 
#7159)

**Related Issue:** #7039 

## Summary

This PR will allow trailing decimal separator while user is editing the
input value in `calcite-input` & `calcite-input-number`

Before the Change:

- If the user removes the `1` value from `0.00001` , the input will be
sanitized and the new value will be `0`
- If the user removes the `1` value from `0.1` , the input will be
sanitized and the new value will be `0`

After the Change:

- If the user removes the `1` value from `0.01` , the input value will
be `0.0`
- If the user removes the `1` value from `0.1` , the input value will be
`0.`
@anveshmekala anveshmekala added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jun 29, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jun 30, 2023
@geospatialem
Copy link
Member

Verified on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 5 A few days of work, definitely requires updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Milestone
2023 July Priorities
Development

No branches or pull requests
4 participants
@geospatialem @benelan @anveshmekala @nid13240