Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Color Picker] Slider drag will reset to the opposite side of the component #7004

Closed
1 of 2 tasks
geospatialem opened this issue May 23, 2023 · 2 comments
Closed
1 of 2 tasks

[Color Picker] Slider drag will reset to the opposite side of the component #7004

geospatialem opened this issue May 23, 2023 · 2 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 3 A day or two of work, likely requires updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that.
Milestone
1.4.1 May patch -...

Comments

@geospatialem
Copy link
Member

geospatialem commented May 23, 2023 •
edited
Loading

Actual Behavior

The color-picker component's slide drag will reset to the opposite side of the component, bouncing back to the beginning of the component.

Expected Behavior

  • The component's slider should not reset to the opposite side when dragging past the handle.
  • If possible, revert the sizing of the scroll bar to be more minimal (similar to 1.3.1)

Reproduction Sample

https://codepen.io/geospatialem/pen/LYgqzQd

Reproduction Steps

  1. Open the sample
  2. Drag the slider all the way to the right on the component
  3. Observe the slider bounces to the opposite side of the component

Reproduction Version

1.4.0

Relevant Info

No response

Regression?

1.3.1

Priority impact

p1 - need for current milestone

Impact

No response

Esri team

ArcGIS Online
@geospatialem geospatialem added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. p - high Issue should be addressed in the current milestone, impacts component or core functionality 1 - assigned Issues that are assigned to a sprint and a team member. regression Issues that are caused by changes in a release, but were working before that. estimate - 3 A day or two of work, likely requires updates to tests. labels May 23, 2023
@github-actions github-actions bot added impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone ArcGIS Online Issues logged by ArcGIS Online team members. labels May 23, 2023
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels May 23, 2023
@jcfranco jcfranco mentioned this issue May 24, 2023
Merged
jcfranco added a commit that referenced this issue May 24, 2023
@jcfranco
fix(color-picker): prevent hue slider thumb from wrapping when dragge…
2d14a16 
…d near/past the edge (#7009)

**Related Issue:** #7004

## Summary

Restores the fix from
#4734, which got
unintentionally removed in #2841.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels May 24, 2023
@github-actions github-actions bot assigned geospatialem and unassigned jcfranco May 24, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels May 24, 2023
@geospatialem
Copy link
Member Author

Verified in 1.4.1-next.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 3 A day or two of work, likely requires updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that.
Projects
None yet
Milestone
1.4.1 May patch - Bugs only
Development

No branches or pull requests
2 participants
@jcfranco @geospatialem