Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Child list-items do not appear in filter results #6574

Closed
nwhittaker opened this issue Mar 7, 2023 · 2 comments
Closed

Child list-items do not appear in filter results #6574

nwhittaker opened this issue Mar 7, 2023 · 2 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 8 Requires input from team, consider smaller steps. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Milestone
1.4.1 May patch -...

Comments

@nwhittaker
Copy link
Contributor

Actual Behavior

Matching children are absent from a <calcite-list> element's filtered results.

Expected Behavior

Matching children are present in a <calcite-list> element's filtered results.

Reproduction Sample

https://codepen.io/nwhittaker-esri/pen/bGxeMVq

Reproduction Steps

  1. Visit the sample
  2. Expand the Rivers list-item to see its child list-item named Estuaries
  3. Type "Estuaries" into the list's filter input

Reproduction Version

1.0.8

Relevant Info

No response

Regression?

No response

Priority impact

p2 - want for current milestone

Impact

A blocker for migrating the Field Map web app to use a <calcite-list> element for managing lists of nested layers.

Esri team

ArcGIS Field Apps
@nwhittaker nwhittaker added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Mar 7, 2023
@github-actions github-actions bot added impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. labels Mar 7, 2023
@nwhittaker nwhittaker mentioned this issue Mar 17, 2023
Closed
@geospatialem geospatialem added p - high Issue should be addressed in the current milestone, impacts component or core functionality estimate - 8 Requires input from team, consider smaller steps. labels May 2, 2023
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label May 2, 2023
@driskull driskull self-assigned this May 22, 2023
@driskull driskull added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels May 22, 2023
driskull added a commit that referenced this issue May 23, 2023
@driskull
fix(list): child list-items do not appear in filter results #6574
6cc5940
@driskull driskull mentioned this issue May 23, 2023
Merged
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels May 24, 2023
driskull added a commit that referenced this issue May 24, 2023
@driskull
fix(list): filter nested children correctly (#6989)
67ca03b 
**Related Issue:** #6574

## Summary

- Refactors and fixes filtering logic in the list component.
- Starts with the filtered list items that are not children of any other
list items
- Then works its way up the dom using closest to get any parent groups
or list items and sets their `hidden` property if necessary.
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels May 24, 2023
@github-actions github-actions bot assigned geospatialem and unassigned driskull May 24, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels May 24, 2023
@geospatialem
Copy link
Member

Verified in 1.4.1-next.2

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 8 Requires input from team, consider smaller steps. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Milestone
1.4.1 May patch - Bugs only
Development

No branches or pull requests
4 participants
@jcfranco @nwhittaker @driskull @geospatialem