Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calcite-progress has incomplete animation in RTL #6569

Closed
ethanbdev opened this issue Mar 6, 2023 · 3 comments
Closed

calcite-progress has incomplete animation in RTL #6569

ethanbdev opened this issue Mar 6, 2023 · 3 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Web Analysis Issues logged by ArcGIS Web Analysis team members bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 3 A day or two of work, likely requires updates to tests. i18n-l10n issues dealing with internationalization/localization impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
1.6.0 - Low risk ...

Comments

@ethanbdev
Copy link
Contributor

Actual Behavior

The animation does not use the entire progress bar

Expected Behavior

Both RTL and LTR should have a similar animation, using the entire progress bar

Reproduction Sample

https://codepen.io/eborgen/pen/LYJjmEp?editors=1000

Reproduction Steps

Observed in the codepen, change the direction to ltr for comparison

Also can be seen on the doc site after changing direction:
https://developers.arcgis.com/calcite-design-system/components/progress/

Reproduction Version

1.0.7

Relevant Info

Windows 10, Chrome Version 110.0.5481.178 (Official Build) (64-bit)

Regression?

No response

Priority impact

p2 - want for current milestone

Impact

Its already in production, would be hoping for a fix by the R2 timeline.

Affects both RTL supported languages in the map viewer

Esri team

ArcGIS Web Analysis
@ethanbdev ethanbdev added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Mar 6, 2023
@github-actions github-actions bot added impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone ArcGIS Web Analysis Issues logged by ArcGIS Web Analysis team members labels Mar 6, 2023
@ethanbdev
Copy link
Contributor Author

BYS issue: https://github.com/ArcGIS/I18N-BYS-Bugs/issues/14165
CR-BY-Beyondsoft_I18N,QV-A-Bug,QV-S-New,QV-C-I18N,QV-C-AR;HE,QV-B-Low

Web analysis issue: https://devtopia.esri.com/WebGIS/arcgis-web-analysis/issues/2611

@ethanbdev ethanbdev added the i18n-l10n issues dealing with internationalization/localization label Mar 6, 2023
@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. labels May 2, 2023
@geospatialem geospatialem added this to the 2023 July Priorities milestone May 2, 2023
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label May 2, 2023
@macandcheese macandcheese mentioned this issue Jul 5, 2023
Closed
3 tasks
@anveshmekala anveshmekala self-assigned this Aug 10, 2023
@anveshmekala anveshmekala added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Aug 10, 2023
@anveshmekala anveshmekala mentioned this issue Aug 11, 2023
Merged
@anveshmekala anveshmekala added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Aug 11, 2023
anveshmekala added a commit that referenced this issue Aug 14, 2023
@anveshmekala
fix(progress): completes animation for dir='rtl' (#7511)
c5d6ada 
**Related Issue:** #6569 

## Summary

Animates the `calcite-progress` over the complete length of the track
when `dir='rtl'`
@anveshmekala anveshmekala added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Aug 14, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Aug 14, 2023
@geospatialem
Copy link
Member

Verified in 1.6.0-next.6

verify-rtl-progress-animation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Web Analysis Issues logged by ArcGIS Web Analysis team members bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 3 A day or two of work, likely requires updates to tests. i18n-l10n issues dealing with internationalization/localization impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
1.6.0 - Low risk issues only
Development

No branches or pull requests
3 participants
@geospatialem @ethanbdev @anveshmekala