Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Accordion Item] Stretch slotted actions to fill height of component #6565

Closed
macandcheese opened this issue Mar 4, 2023 · 3 comments
Closed

[Accordion Item] Stretch slotted actions to fill height of component #6565

macandcheese opened this issue Mar 4, 2023 · 3 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - low Issue is non core or affecting less that 10% of people using the library
Milestone
2024-10-29 - Oct ...

Comments

@macandcheese
Copy link
Contributor

macandcheese commented Mar 4, 2023 •
edited
Loading

Description

Noticed this while testing out #6561 / #2884 (comment).

Slotted actions don't stretch to fill the height:

Screen Shot 2023-03-04 at 10 49 10 AM

Acceptance Criteria

We should follow how we handle this in other components - stretching the actions to fill when we expect the component as a slotted child, for example in Alert:

Screen Shot 2023-03-04 at 10 52 27 AM

Relevant Info

No response

Which Component

Accordion Item

Example Use Case

No response

Esri team

Calcite (design)
@macandcheese macandcheese added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Mar 4, 2023
@github-actions github-actions bot added the Calcite (design) Issues logged by Calcite designers. label Mar 4, 2023
@macandcheese macandcheese added the impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone label Mar 28, 2023
@geospatialem geospatialem mentioned this issue Sep 18, 2023
Closed
13 tasks
@geospatialem geospatialem added p - low Issue is non core or affecting less that 10% of people using the library estimate - 2 Small fix or update, may require updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Jan 22, 2024
@brittneytewks brittneytewks removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Apr 3, 2024
@josercarcamo josercarcamo self-assigned this May 2, 2024
@josercarcamo josercarcamo added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels May 2, 2024
@josercarcamo josercarcamo mentioned this issue May 2, 2024
Merged
@geospatialem
Copy link
Member

Adding context to the above - once the above lands ✈️ we have a follow-up internal documentation update (issue 703).

josercarcamo added a commit that referenced this issue Oct 7, 2024
@josercarcamo
feat(accordion-item): stretch slotted actions to fill its height (#9250)
ba46dc4 
**Related Issue:** #6565 

## Summary
Made the height of the action item 100% so that it fills its available height.
@josercarcamo josercarcamo added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Oct 7, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned josercarcamo Oct 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Oct 7, 2024

🍠 Verified on 2.14.0-next.6
image

@DitwanP DitwanP closed this as completed Oct 7, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Milestone
2024-10-29 - Oct Milestone
Development

No branches or pull requests
5 participants
@macandcheese @geospatialem @DitwanP @brittneytewks @josercarcamo