Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use composed-offset-position package instead of embedded ponyfill 🐴 #6547

Closed
jcfranco opened this issue Mar 1, 2023 · 1 comment
Closed

Use composed-offset-position package instead of embedded ponyfill 🐴 #6547

jcfranco opened this issue Mar 1, 2023 · 1 comment
Assignees
@jcfranco
Labels
4 - verified Issues that have been released and confirmed resolved. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. p - low Issue is non core or affecting less that 10% of people using the library refactor Issues tied to code that needs to be significantly reworked.
Milestone
2023 April Priori...

Comments

@jcfranco
Copy link
Member

jcfranco commented Mar 1, 2023

Description

#6520 copied a util while the composed offset ponyfill package was in progress. Once stable, we can use https://www.npmjs.com/package/composed-offset-position instead of embedding it here.

Proposed Advantages

Picking upstream fixes/enhancements and less code on our side.

Which Component

https://github.com/Esri/calcite-components/blob/ba8c0688dd92a99e147f0e6434a969fef10ab3e3/src/utils/floating-ui.ts#L64

Relevant Info

No response
@jcfranco jcfranco added refactor Issues tied to code that needs to be significantly reworked. p - low Issue is non core or affecting less that 10% of people using the library 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. labels Mar 1, 2023
@jcfranco jcfranco mentioned this issue Apr 6, 2023
Merged
jcfranco added a commit that referenced this issue Apr 8, 2023
@jcfranco
refactor: use composed-offset-position instead of custom utils (#6710)
6229ac6 
**Related Issue:** #6547

## Summary

The composed offset position code is now available as a package we can
use instead. See
floating-ui/floating-ui#2160 (comment)
for more context.
@jcfranco jcfranco self-assigned this Apr 25, 2023
@jcfranco jcfranco added 4 - verified Issues that have been released and confirmed resolved. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Apr 25, 2023
@jcfranco
Copy link
Member Author

@geospatialem This got installed in the April milestone, but I forgot to update the issue. Marking as self-verified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcfranco jcfranco

Labels
4 - verified Issues that have been released and confirmed resolved. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. p - low Issue is non core or affecting less that 10% of people using the library refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2023 April Priorities - No breaking c...
Development

No branches or pull requests
1 participant
@jcfranco