Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Action Bar] Improve Tooltip options #6393

Closed
2 tasks
geospatialem opened this issue Jan 31, 2023 · 5 comments
Closed
2 tasks

[Action Bar] Improve Tooltip options #6393

geospatialem opened this issue Jan 31, 2023 · 5 comments
Labels
0 - new New issues that need assignment. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. ArcGIS Online Issues logged by ArcGIS Online team members. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation.

Comments

@geospatialem
Copy link
Member

geospatialem commented Jan 31, 2023

Description

Tooltips in action-bar have a lag when appearing or disappearing. Examples include:

  • Moving the mouse over the action, it takes too long for the tooltip to show up
  • Moving the mouse to another action, it takes too long for the tooltip still on the other action to disappear and for the new tooltip to display
  • When clicking on an action, the tooltip still shows

Acceptance Criteria

It isn't intuitive to add tooltip to the actions of the action-bar. A few improvements could include:

  • Ability to hide the tooltip when action-bar is expanded via a prop on the action-bar, such as enableTooltip and use the action labels.
    • Would also let the action-bar provide logic about showing/hiding the tooltip when collapsed/expanded.
    • Removes redundant tooltip with expanded action-bar
  • If using the action-bar's expand-tooltip slot, allows more control over props, such as placement or offset

Relevant Info

Teams discussion with ArcGIS Online team members.

Which Component

action-bar and tooltip is most noticeable, also includes action, action-pad, flow-item, and tooltip.

Example Use Cases

  • Action-bar with tooltip
    • Hover over the expand action and observe the delayed appearance, hover off to observe the delayed close.

Esri team

ArcGIS Online

@geospatialem geospatialem added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jan 31, 2023
@github-actions github-actions bot added the ArcGIS Online Issues logged by ArcGIS Online team members. label Jan 31, 2023
@geospatialem geospatialem changed the title [Action Bar] Improve Tooltip timing and options [Action, Action Bar, Action Pad, Flow, Tooltip] Improve Tooltip timing and options Jan 31, 2023
@macandcheese
Copy link
Contributor

I believe this is relevant for all Tooltips, not just ones associated with Actions / Action Bar (though they are most commonly seen example).

Regarding the lag, we should consider a faster default delay along with the ability to disable the delay entirely (not the animation, which is already possible with css variable override).

We could consider allowing this delay to be customized but would likely lead to fragmentation as correctly noted by @AdelheidF and the ability to disable a (faster) default should be sufficient.

@geospatialem geospatialem added the epic Large scale issues to be broken up into sub-issues and tracked via sprints and/or project. label Jan 31, 2023
@geospatialem geospatialem changed the title [Action, Action Bar, Action Pad, Flow, Tooltip] Improve Tooltip timing and options [Action Bar] Improve Tooltip options Jan 31, 2023
@geospatialem geospatialem removed the epic Large scale issues to be broken up into sub-issues and tracked via sprints and/or project. label Jan 31, 2023
@geospatialem
Copy link
Member Author

geospatialem commented Jan 31, 2023

Updating to reflect the original discussion, reference #6396 for specific timing considerations of tooltip across Calcite.

@geospatialem geospatialem added ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Mar 29, 2023
@geospatialem
Copy link
Member Author

Added an issue creation priority label of p2 - need for upcoming milestone for the Map Viewer team, which wasn't available at the time of issue creation due to the impact.

@geospatialem geospatialem added design Issues that need design consultation prior to development. 1 - assigned Issues that are assigned to a sprint and a team member. and removed needs triage Planning workflow - pending design/dev review. 0 - new New issues that need assignment. labels Apr 17, 2023
@geospatialem geospatialem added ready for dev Issues ready for development implementation. and removed design Issues that need design consultation prior to development. labels Jun 6, 2023
@geospatialem geospatialem added 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jun 6, 2023
@ashetland ashetland added design Issues that need design consultation prior to development. and removed ready for dev Issues ready for development implementation. labels Jun 6, 2023
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels Jun 6, 2023
@ashetland
Copy link
Contributor

ashetland commented Jun 7, 2023

Please see this comment and subsequent comments on epic #6396 for timing information and designs for improving behaviors when multiple Tooltips are adjacent to each other.

At this time, we think providing automatic logic for showing/hiding Tooltips when Action Bar is collapsed/expanded isn't necessary as this can currently be achieved without it and may cause unexpected problems depending on the particular scenario.

I have been unable to reproduce "When clicking on an action, the tooltip still shows". Can we document this bug as a separate issue?

@ashetland ashetland added ready for dev Issues ready for development implementation. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed design Issues that need design consultation prior to development. labels Jun 8, 2023
@ashetland ashetland removed their assignment Jun 8, 2023
@geospatialem geospatialem added 0 - new New issues that need assignment. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jun 8, 2023
@geospatialem geospatialem added the p - medium Issue is non core or affecting less that 60% of people using the library label Jun 22, 2023
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jun 22, 2023
@geospatialem
Copy link
Member Author

Closing per #6393 (comment)

@brittneytewks brittneytewks added the design Issues that need design consultation prior to development. label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. ArcGIS Online Issues logged by ArcGIS Online team members. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation.
Projects
None yet
Development

No branches or pull requests

5 participants