Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List: inconsistent focus behavior when when using content slots #5899

Closed
benelan opened this issue Dec 5, 2022 · 2 comments
Closed

List: inconsistent focus behavior when when using content slots #5899

benelan opened this issue Dec 5, 2022 · 2 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers.
Milestone
2023 January Prio...

Comments

@benelan
Copy link
Member

benelan commented Dec 5, 2022

Actual Behavior

Focus is inconsistent when using the content-end, content-start, and content slots

Expected Behavior

Focus works the same as it does when not using the content slots

Reproduction Sample

https://esri.github.io/calcite-components/?path=/story/components-list--start-and-end-content-slots

Reproduction Steps

Click back and forth between the list items a bunch of times. Sometimes the focus ring will display and sometimes it won't

Reproduction Version

next.633

Relevant Info

Note: the content slot doesn't exist in next.633, I found the bug while testing #5876

Regression?

No response

Impact

No response

Esri team

Calcite (dev)
@benelan benelan added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. and removed needs triage Planning workflow - pending design/dev review. labels Dec 5, 2022
@github-actions github-actions bot added Calcite (dev) Issues logged by Calcite developers. needs triage Planning workflow - pending design/dev review. labels Dec 5, 2022
@benelan benelan added this to the 2023 January Priorities milestone Dec 5, 2022
@benelan benelan added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Dec 5, 2022
driskull added a commit that referenced this issue Dec 5, 2022
@driskull
fix(list, list-item): Fix focus behavior when clicking on an item. #5899
0b45776
@driskull driskull mentioned this issue Dec 5, 2022
Merged
driskull added a commit that referenced this issue Dec 6, 2022
@driskull
fix(list, list-item): Fix focus behavior when clicking on an item (#5901
552e28f 
)

**Related Issue:** #5899

## Summary

fix(list, list-item): Fix focus behavior when clicking on an item.
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Dec 6, 2022
@github-actions github-actions bot assigned benelan and geospatialem and unassigned driskull Dec 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

Installed and assigned for verification.

@benelan benelan removed their assignment Dec 8, 2022
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. needs triage Planning workflow - pending design/dev review. labels Dec 9, 2022
@geospatialem
Copy link
Member

Verified on next.664 with the following Codepen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers.
Projects
None yet
Milestone
2023 January Priorities
Development

No branches or pull requests
3 participants
@driskull @geospatialem @benelan