Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

value-list: Unstable test #5739

Closed
driskull opened this issue Nov 10, 2022 · 3 comments
Closed

value-list: Unstable test #5739

driskull opened this issue Nov 10, 2022 · 3 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. p - high Issue should be addressed in the current milestone, impacts component or core functionality testing Issues related to automated or manual testing.

Comments

@driskull
Copy link
Member

Test type

e2e

Which Component(s)

value-list

Unstable Tests

it.skip("is drag and drop list accessible", async () => {

Test error, if applicable

calcite-value-list › drag and drop › is drag and drop list accessible
    expect(received).toBe(expected) // Object.is equality
    Expected: "Reordering One, current position 1 of 3."
    Received: ""
      271 |       await page.waitForChanges();
      272 |
    > 273 |       expect(assistiveTextElement.textContent).toBe(
          |                                                ^
      274 |         `Reordering ${itemLabel}, current position ${startIndex + 1} of ${items.length}.`
      275 |       );
      276 |
      at Object.<anonymous> (src/components/value-list/value-list.e2e.ts:273:48)
          at runMicrotasks (<anonymous>)

PR skipped, if applicable

#5738

Additional Info

No response
@driskull driskull added testing Issues related to automated or manual testing. p - high Issue should be addressed in the current milestone, impacts component or core functionality 0 - new New issues that need assignment. labels Nov 10, 2022
@anveshmekala anveshmekala self-assigned this Nov 10, 2022
@anveshmekala anveshmekala added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Feb 13, 2023
@anveshmekala anveshmekala mentioned this issue Feb 13, 2023
Merged
anveshmekala added a commit that referenced this issue Feb 25, 2023
@anveshmekala
fix(value-list): add back instructions for screen reader when drag ha…
b822f25 
…ndle is activated (#6402)

**Related Issue:** #6401 

## Summary

This PR will add back instructions for screen reader when drag handle is
activated via `Space` key.

Sidebar: This will also cover #5739
@anveshmekala anveshmekala added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Feb 28, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@anveshmekala
Copy link
Contributor

the test is stable and the failure reported earlier is a true error case. closing this as verified.

@anveshmekala anveshmekala added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Feb 28, 2023
@geospatialem
Copy link
Member

Closing this as it has been verified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. p - high Issue should be addressed in the current milestone, impacts component or core functionality testing Issues related to automated or manual testing.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@driskull @alisonailea @geospatialem @anveshmekala