Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calcite-slider throws error #5321

Closed
AdelheidF opened this issue Sep 14, 2022 · 3 comments
Closed

calcite-slider throws error #5321

AdelheidF opened this issue Sep 14, 2022 · 3 comments
Assignees
@geospatialem @benelan
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. p - high Issue should be addressed in the current milestone, impacts component or core functionality research Issues that require more in-depth research or multiple team members to resolve or make decision.
Milestone
Sprint 2022/10/10...

Comments

@AdelheidF
Copy link

AdelheidF commented Sep 14, 2022 •
edited
Loading

Actual Behavior

When clicking left of handle on slider an error occurs and no calciteSliderInput event gets called. After that nothing works anymore. This started with beta.91.

image

Expected Behavior

no errors

Reproduction Sample

https://codepen.io/afreitag/pen/ExLNOeN

Reproduction Steps

open the codepen and the browser console
click twice on the right side of the handle, all good
click left of the handle and you'll see the error

Reproduction Version

beta.93 and latest next

Relevant Info

No response

Regression?

beta.90
@AdelheidF AdelheidF added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Sep 14, 2022
@geospatialem geospatialem added research Issues that require more in-depth research or multiple team members to resolve or make decision. and removed needs triage Planning workflow - pending design/dev review. labels Oct 12, 2022
@RalucaNicola
Copy link
Member

I ran into the same issue with the calcite react components. I have a repro here: https://codesandbox.io/s/brave-benz-cfi8vg?file=/src/index.js

@jcfranco jcfranco added the p - high Issue should be addressed in the current milestone, impacts component or core functionality label Oct 20, 2022
@jcfranco jcfranco self-assigned this Oct 20, 2022
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Oct 20, 2022
@jcfranco jcfranco mentioned this issue Oct 20, 2022
Closed
@jcfranco jcfranco mentioned this issue Oct 20, 2022
Merged
jcfranco added a commit that referenced this issue Oct 20, 2022
@jcfranco
fix(slider): fix slider (single-value) error when clicking range (#5533)
519df13 
#5321
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Oct 20, 2022
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@AdelheidF
Copy link
Author

looks good with next.603

@AdelheidF AdelheidF added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Oct 21, 2022
anveshmekala added a commit that referenced this issue Oct 26, 2022
@anveshmekala @benelan
@jcfranco @github-actions @driskull @geospatialem @Elijbet @alisonailea
feat(button): add built-in translations (#5447)
7bc4c50 
* feat(button): add built-in translations

* change watcher order

* remove intl default test assertion

* cleanup

* handle edge case

* fix build errors

* docs(conventions): update style guide (#5530)

* fix(slider): fix slider (single-value) error when clicking range (#5533)

#5321

* 1.0.0-next.603

* ci(screener): reenable screener on pushes to master to update baseline (#5528)

* ci(screener): renable screener on pushes to master to update baseline

* cleanup

Co-authored-by: Ben Elan <benelan@users.noreply.github.com>

* fix: components should only react to primary button pointer events. (#5519)

* fix: components should only react to primary pointer events.

* cleanup. add pointerdown

* fix test

* make sure primary?

* review fixes

* 1.0.0-next.604

* feat(date-picker, input-date-picker): add numberingSystem property (#5488)

* feat(date-picker): add numberingSystem property

* docs(date-picker): cleanup lang/numberingSystem selection code

* feat(input-date-picker): add numberingSystem property [WIP]

* add stories

* cleanup

* fix spec test

* cleanup

* test(date-picker-day): fix failing disabled commonTest

* merge master

* cleanup

* review cleanups

* skip (de)localization when formatter is not initialized

* cleanup and add a spec test

* don't init formatter until necessary

* final cleanup

* replace stepped stories and change locale to lang

* test(input-date-picker): add dark theme class to darkThemeRTL story

Co-authored-by: Ben Elan <benelan@users.noreply.github.com>

* 1.0.0-next.605

* docs: consistent api styling + define card thumbnailPosition (#5518)

* docs(card): defined thumbnailPosition and consistent api styling across component

* fix typo

* remove extraneous dash

* add backticks to comps

* add b + c component consistency

* edits

* doc feedback

* fix(value-list-item): Change drag handle color. (#5543)

* 1.0.0-next.606

* fix: add custom logic for floating-ui positioning across shadow DOM in non-Chromium browsers (#5542)

* fix: add custom code for floating-ui positioning across shadow DOM in non-Chrome browsers

* tidy up

* fix conditional to avoid setting up fix for non-browser environments

* provide a way to opt-out of fix in favor of performance

* fix: fix jarring positioning when a closed component is first opened (#5484)

* fix: fix jarring positioning when a closed component is first opened

* uncomment actual fix and switch story to be stepped

* tweak story to capture initial positioning

* fix typo

* add missing setAttr argument

* add delay before screenshot test setup

* revisit approach to preserve debounced internal repositioning calls and correct positioning

* drop unnecessary story

* tidy up

* fix hydrate build

* restore leading option

* update test

* tweak positioning

* drop scale transformto have correct dimensions initially
* reposition immediately on componentDidLoad

* update tests

* revert index.html updates

* use transitions to reset positioning

* fix test.

Co-authored-by: Matt Driscoll <mdriscoll@esri.com>

* 1.0.0-next.607

* fix(calcite-loader, calcite-input-message): drop active in favor of hidden (#5537)

* fix(calcite-loader, calcite-input-message): drop active in favor of hidden

* changes applied to input-message

* modify render assertion in the tests

* remove redundant hidden prop along with documentation (global attribute)

* add the link to mdn hidden attribute

* 1.0.0-next.608

* feat(flow-item): Add calciteFlowItemScroll event (#5547)

* feat(flow-item): Add scroll event. (#5546)

* add a test

* 1.0.0-next.609

* ci: adds w3c url for a11y issue filing (#5556)

ci: update need info url for a11y

* fix(date-picker): display correct date format order in header for zh-CN locale. (#5534)

fix(date-picker): display correct date format order in header for zh-CN locale

* 1.0.0-next.610

* fix(stepper-item): make sure numberingSystem is rendered on load (#5640)

* fix(stepper-item): set numberingSystem in render block

* cleanup

* cleanup the cleanup

Co-authored-by: Ben Elan <benelan@users.noreply.github.com>

* 1.0.0-next.611

* feedback changes

* remove browser build conditional

* fix(slider): dragging range fires input event (#5641)

#5449

* fix(tooltip): Prevent opening when closeOnClick is true and referenceElement is clicked quickly (#5643)

* fix(tooltip): Stop hover event when closeOnClick is true and click occurs. (#5538)

* add test

* review cleanup

* fix(types): fix type issue caused by unintentionally moving @floating-ui/dom as a dev dependency (#5649)

* avoid fetching in hydrate builds

* resolve conflicts

* clean up

* more cleanup

Co-authored-by: Ben Elan <belan@esri.com>
Co-authored-by: JC Franco <jfranco@esri.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ben Elan <benelan@users.noreply.github.com>
Co-authored-by: Matt Driscoll <mdriscoll@esri.com>
Co-authored-by: Kitty Hurley <khurley@esri.com>
Co-authored-by: Eliza Khachatryan <eli97736@esri.com>
Co-authored-by: Alison Stump <alisonailea@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@benelan benelan

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. p - high Issue should be addressed in the current milestone, impacts component or core functionality research Issues that require more in-depth research or multiple team members to resolve or make decision.
Projects
None yet
Milestone
Sprint 2022/10/10 - 2022/10/21
Development

No branches or pull requests
5 participants
@jcfranco @geospatialem @RalucaNicola @benelan @AdelheidF