Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal: Add backgroundColor property #527

Closed
cosbyr opened this issue Apr 28, 2020 · 4 comments
Closed

Modal: Add backgroundColor property #527

cosbyr opened this issue Apr 28, 2020 · 4 comments
Assignees
Labels
design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request.

Comments

@cosbyr
Copy link
Contributor

cosbyr commented Apr 28, 2020

  • We would like the ability to conditionally change the background color of the content slot of the Modal
  • If it makes sense to have separate properties for the modal footer and header that may be helpful to other users down the line as well but we are primarily concerned with the content div.

While the background-color attribute could be added programmatically to the shadowDom modal__content div I think it would be easier for users as a property of calcite-modal.

@macandcheese macandcheese added component-modal enhancement Issues tied to a new feature or request. labels Apr 28, 2020
@macandcheese
Copy link
Contributor

Would having the choice between white and our light grey background value (#f3f3f3) work here (and reciprocal dark theme value)?

@cosbyr
Copy link
Contributor Author

cosbyr commented Apr 28, 2020

@macandcheese I think that would work, though it might be nice to be able to put in your own hex value. Coincidentally we were going to use (#f4f4f4) :)

@macandcheese macandcheese added the design Issues that need design consultation prior to development. label Apr 30, 2020
@paulcpederson paulcpederson self-assigned this May 18, 2020
@paulcpederson paulcpederson added this to the 🔨 v1-beta.33 milestone Jul 15, 2020
@paulcpederson
Copy link
Member

@cosbyr ok, background-color="grey" should give you the official calcite off-white background color as of v1.0.0-beta.33

@cosbyr
Copy link
Contributor Author

cosbyr commented Jul 16, 2020

@paulcpederson thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request.
Projects
None yet
Development

No branches or pull requests

3 participants