Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date Picker is not localized for Bulgarian (bg) #3602

Closed
zaramatheson opened this issue Nov 30, 2021 · 15 comments
Closed

Date Picker is not localized for Bulgarian (bg) #3602

zaramatheson opened this issue Nov 30, 2021 · 15 comments
Assignees
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. p - high Issue should be addressed in the current milestone, impacts component or core functionality

Comments

@zaramatheson
Copy link

zaramatheson commented Nov 30, 2021

AGOL introduced Bulgarian as a new language for this release and it looks like Calcite Date Picker has not been updated with it:
Locale = bg

https://codepen.io/zmatheson/pen/YzrPwdb?editors=1010

cc @jcfranco

@zaramatheson zaramatheson added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Nov 30, 2021
@github-actions
Copy link
Contributor

More information is required to proceed with this issue:

  • Copy the appropriate issue template format and paste it into a comment, providing all of the requested items

This issue will be automatically closed in three days if the information is not provided. Thanks for your understanding.

@github-actions github-actions bot added the need more info Issues that are missing information and/or a clear, actionable description. label Nov 30, 2021
@zaramatheson
Copy link
Author

Description

AGOL introduced Bulgarian as a new language for this release and it looks like Calcite Date Picker has not been updated with it:
Locale = bg

Acceptance Criteria

Support Bulgarian Languague

Relevant Info

Which Component

calcite-input-date-picker

Example Use Case

ArcGIS Online Map Viewer Time Slider, Filter,

@benelan benelan removed the need more info Issues that are missing information and/or a clear, actionable description. label Nov 30, 2021
@driskull
Copy link
Member

driskull commented Dec 2, 2021

@jcfranco @paulcpederson Do you know the process for localization within calcite for this? Its kind of an outlier because we don't do any other localization within calcite.

@driskull driskull added the p - high Issue should be addressed in the current milestone, impacts component or core functionality label Dec 2, 2021
@jcfranco jcfranco removed the needs triage Planning workflow - pending design/dev review. label Dec 2, 2021
@jcfranco jcfranco added this to the Sprint 12/6 - 12/17 milestone Dec 2, 2021
@bsvensson
Copy link
Member

FYI - The actual Bulgarian CLDR strings can be found in https://github.com/unicode-org/cldr-json/blob/main/cldr-json/cldr-dates-modern/main/bg/ca-generic.json
Compare the English (World) strings in https://github.com/unicode-org/cldr-json/blob/main/cldr-json/cldr-dates-modern/main/en-001/ca-gregorian.json

@jcfranco
Copy link
Member

jcfranco commented Dec 2, 2021

Deferring to @paulcpederson since he introduced those localization files. We should add this info to a wiki page for posterity. cc @benelan

@paulcpederson
Copy link
Member

We had Babak Bolour and Rajeev Krishnan send us these json files. I spec'd what we'd need and they delivered a folder of them which I pr'd in.

@paulcpederson
Copy link
Member

Now that we dropped ie11 we could theoretically start using Intl for this as I think the api's have good enough support IIRC, but I could be wrong on that one...

@driskull
Copy link
Member

driskull commented Dec 2, 2021

That would be ideal so we don't have to manage this :)

@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Jan 6, 2022
@jcfranco
Copy link
Member

jcfranco commented Jan 6, 2022

Thanks for the info, @paulcpederson! I'll work on a prototype to see if we can leverage Intl. In the meantime, I'll reach out to get the missing localization file.

@jcfranco
Copy link
Member

jcfranco commented Jan 6, 2022

Early prototyping shows that Intl does not have the necessary info to replace the localization files 1-1. Some items are not available or don't match from Intl.DateTimeFormat.formatToParts:

  • default-calendar - this may be fine since it doesn't seem to be used at the moment
  • weekStart - missing 🚫
  • unitOrder/placeholder - it looks like these could be inferred from the order of formatToParts, but we'd need to confirm
  • days.abbreviated - missing 🚫
  • numerals - this could be fine if we format each day individually
  • days.narrow/months.narrow - the short date style show numbers
  • year.suffix - this could be obtained from the year separator, but we'd need a list of locales to do this for since all of them seem to have a separator

The rest from the DateLocaleData interface can be generated dynamically.

IMO, not having weekStart is a showstopper.

@driskull
Copy link
Member

driskull commented Jan 6, 2022

bummer :(

@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jan 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2022

Installed and assigned for verification.

@AdelheidF
Copy link

AdelheidF commented Jan 12, 2022

Changed the codepen to beta.74 and now I see this. I don't think it's correct for Bulgarian, the input box doesn't show DD.MM.YYYY, like in all other languages.
The calendar is good now.

https://codepen.io/afreitag/pen/KKXrGKE

image

I also noticed none of the Chinese language codes work. They stay English, see codepen.

image

@AdelheidF AdelheidF added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jan 12, 2022
@benelan benelan assigned jcfranco and unassigned benelan Jan 12, 2022
@jcfranco
Copy link
Member

jcfranco commented Jan 12, 2022

the input box doesn't show DD.MM.YYYY, like in all other languages.

I believe this is expected. The placeholder format comes from the bg localization file. cc @raje9276

I also noticed none of the Chinese language codes work. They stay English, see codepen.

I created #3925 for this.

@AdelheidF AdelheidF added 4 - verified Issues that have been released and confirmed resolved. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jan 12, 2022
@AdelheidF
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Development

No branches or pull requests

7 participants