-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Component: Meter #2249
Comments
gonna jump on this design this week |
Edited - Aug 2023 to hide outdated designs. |
Leaving discussion open for this until next Wednesday 6/16 |
Alrighty! Moving this one over to developer hands for a future sprint |
@jcfranco @julio8a I think new components need to go through an API design process before being implemented. Just looking at the designs, it's not super clear on how the API for this component should be implemented. The native HTML meter element has the following attributes: min, max, low, high, optimum, value. It seems like this component:
I think for new components we should maybe have a meeting to go over these requirements first. Its kinda tricky to decipher how the component should behave. I'm not sure this is an issue someone can just grab and implement. |
@driskull I was thinking the API would come from the implementation phase, but we could tweak this of course. Looking closer at the existing summary and your comment, I agree with you that this needs more detail. Along with the design mockups, we should make sure the summary lists the requirements on what this component should do. For example,
Having this would help with the API design, testing and even planning if the scope is too big. We can even work on a requirements starter template to guide this part of the process. @julio8a WDYT? Can we beef up the requirements before tackling this one in this sprint? |
Sounds good @jcfranco. More documented requirements along with the designs should be enough if they are thorough. |
@jcfranco i can provide more details for this |
This is a good candidate for Calcite - consistent design to be used across ArcGIS. Should it be ported from ArcGIS App Components? |
A design task to create a component is assigned to @macandcheese using this issue. Design work needs to be complete for May release for us to implement this component in September. I recommend renaming this component to Progress Indicator or Progress to align with industry standard. @macandcheese, I left some comments for you in the description. |
Some questions to clarify here... We already have a progress component that replicates the native progress element. This issue is to add a new meter component to replicate the native meter element. The two native elements have different use cases and configuration options. Additionally the existing arcGIS component is Adobe's Spectrum has a nice succinct use case distinction between their versions: https://spectrum.adobe.com/page/meter/#Progress-bar-or-meter? |
I'll be sending out a survey post dev-summit. The way our labels work has changed since this initial design work so will update that and reconcile any other changes in requirements that surface from survey. But I imagine it won't be drastically different in appearance.
Likely both, the API for this should follow the native meter element closely. cc @jcfranco |
Updating design work to the June milestone. |
**Related Issue:** #2249 ## Summary Adds new Meter component with a variety of display capabilities. https://github.com/Esri/calcite-design-system/assets/4733155/dfca6fa0-ebb9-45d4-b97d-f749270559b4
Installed and assigned for verification. |
Verified on the
cc @ashetland @SkyeSeitz for Figma UI kit additions. |
Description
A consistently formatted and styled meter component that leverages the native meter element.
User Stories
Consistently display data limits, quotas, disc space, etc.
Can also be useful for item completeness, profile "filled out" progression messaging, etc.
Helpful Details
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meter
Adobe Spectrum's implementation: https://spectrum.adobe.com/page/meter/#Anatomy
They don't seem to leverage the native "levels" that are associated with color, but they DO have consistently placed and formatted descriptive and value text areas.
Online "item completeness":

Enterprise Manager :

The text was updated successfully, but these errors were encountered: