Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: [FAB] defaults to small scale instead of medium #1427

Closed
jcfranco opened this issue Dec 22, 2020 · 4 comments
Closed

Bug: [FAB] defaults to small scale instead of medium #1427

jcfranco opened this issue Dec 22, 2020 · 4 comments
Assignees
@jcfranco
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug.
Milestone
v1.0.0-beta.48

Comments

@jcfranco
Copy link
Member

Summary

Stems from #1167 (comment)

via @macandcheese

It seems like FAB defaults to scale "s" if no scale is provided which seems a little weird as I think all other components default to "m"... and there looks to be a weird RTL styling thing on the demo with alignment (although I don't see the same thing with buttons in RTL so not sure where that is coming from)

Screen Shot 2020-11-24 at 4 27 30 PM

Actual Behavior

FAB defaults to small scale when not provided.

Expected Behavior

FAB defaults to medium scale when not provided.

Reproduction Steps

  1. Create FAB w/o scale attribute/prop.

Relevant Info

@jcfranco jcfranco added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 1 - assigned Issues that are assigned to a sprint and a team member. labels Dec 22, 2020
@jcfranco jcfranco added this to the v1.0.0-beta.48 milestone Dec 22, 2020
@driskull driskull removed their assignment Dec 23, 2020
@driskull
Copy link
Member

Assigning to @asangma. Its just a simple change but we need his approval.

@macandcheese
Copy link
Contributor

We could break the mentioned rtl bug into another issue if needed but seems simple enough to be addressed here as well.

@driskull
Copy link
Member

Yeah I think the RTL is also a small styling issue probably best addressed by one of the designers.

@driskull driskull assigned driskull and unassigned asangma Dec 31, 2020
driskull added a commit that referenced this issue Dec 31, 2020
@driskull
fix(fab)!: default scale property to medium (m). #1427
989c351
@driskull driskull mentioned this issue Dec 31, 2020
Merged
paulcpederson pushed a commit that referenced this issue Jan 4, 2021
@driskull
fix(fab)!: default scale property to medium (m). #1427 (#1436)
027369c 
* fix(fab)!: default scale property to medium (m). #1427

* fix test
@driskull driskull assigned jcfranco and unassigned driskull Jan 5, 2021
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jan 5, 2021
@jcfranco
Copy link
Member Author

jcfranco commented Jan 5, 2021

Verified locally!

@jcfranco jcfranco closed this as completed Jan 5, 2021
@jcfranco jcfranco added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcfranco jcfranco

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug.
Projects
None yet
Milestone
v1.0.0-beta.48
Development

No branches or pull requests
4 participants
@jcfranco @driskull @macandcheese @asangma