Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dialog / Panel] Add css properties for content-top and content-bottom slot spacing #10380

Open
2 of 6 tasks
macandcheese opened this issue Sep 24, 2024 · 0 comments
Open
2 of 6 tasks

[Dialog / Panel] Add css properties for content-top and content-bottom slot spacing #10380

macandcheese opened this issue Sep 24, 2024 · 0 comments
Labels
0 - new New issues that need assignment. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design-tokens Issues requiring design tokens. enhancement Issues tied to a new feature or request. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone needs triage Planning workflow - pending design/dev review.

Comments

@macandcheese
Copy link
Contributor

Check existing issues

Description

I’d like the ability to remove (or otherwise customize) the default padding of the content-top and content-bottom slots of Dialog. This could likely be useful in Panel as well, so adding them in both places seems expected.

Acceptance Criteria

A content-top-space and content-bottom-space css properties are added to Dialog / Panel.

Relevant Info

No response

Which Component

Dialog / Panel

Example Use Case

As a designer, I’d like to remove the padding provided by default in these slots to achieve a specific UI.

Priority impact

impact - p2 - want for an upcoming milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@macandcheese macandcheese added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Sep 24, 2024
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Sep 24, 2024
@macandcheese macandcheese added the design-tokens Issues requiring design tokens. label Sep 24, 2024
@macandcheese macandcheese mentioned this issue Sep 25, 2024
Merged
macandcheese added a commit that referenced this issue Sep 25, 2024
@macandcheese
feat(dialog, panel): Add css properties for background-color (#10387)
d725293 
**Related Issue:** #10093 

## Summary
Adds `--calcite-dialog-background-color` to Dialog
Adds `--calcite-panel-background-color` to Panel

Further token work may occur through related issues: #7180, #10380, etc.
@macandcheese macandcheese mentioned this issue Nov 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design-tokens Issues requiring design tokens. enhancement Issues tied to a new feature or request. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone needs triage Planning workflow - pending design/dev review.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@macandcheese