Skip to content

Commit

Permalink
fix(combobox-item): items align to left when added dynamically (#4176)
Browse files Browse the repository at this point in the history
* fix(combobox-item): items align to left when added dynamically

* add screener test
  • Loading branch information
anveshmekala authored Mar 23, 2022
1 parent 5b3a6bd commit fdca1e9
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/components/combobox-item/combobox-item.scss
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ ul {

.icon--dot {
@apply flex justify-end;
width: var(--calcite-combobox-item-spacing-unit-l);
min-width: var(--calcite-combobox-item-spacing-unit-l);
}

.icon--dot:before {
Expand Down
16 changes: 16 additions & 0 deletions src/components/combobox/combobox.stories.ts
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,21 @@ FlipPositioning.parameters = {
layout: "fullscreen"
};


export const SingleLongLabel = (): string => html`
<calcite-combobox active selection-mode="single" allow-custom-values>
<calcite-combobox-item value="Trees" text-label="Trees">
<calcite-combobox-item
value="CommercialDamageAssessment - Damage to Commercial Buildings"
text-label="CommercialDamageAssessment - Damage to Commercial Buildings & Damage to Residential Buildings "
></calcite-combobox-item>
<calcite-combobox-item value="Sequoia" text-label="Sequoia"></calcite-combobox-item>
<calcite-combobox-item value="Douglas Fir" text-label="Douglas Fir"></calcite-combobox-item>
</calcite-combobox-item>
<calcite-combobox-item value="Rivers" text-label="Rivers"></calcite-combobox-item>
</calcite-combobox>
`;

export const disabled = (): string => html`<calcite-combobox disabled>
<calcite-combobox-item value="Trees" text-label="Trees">
<calcite-combobox-item value="Pine" text-label="Pine"></calcite-combobox-item>
Expand All @@ -268,3 +283,4 @@ export const disabled = (): string => html`<calcite-combobox disabled>
<calcite-combobox-item value="Nasturtium" text-label="Nasturtium"></calcite-combobox-item>
</calcite-combobox-item>
</calcite-combobox>`;

0 comments on commit fdca1e9

Please sign in to comment.