Skip to content

Commit

Permalink
build(angular): chage calcite-components to a dep from peerDep/devDep (
Browse files Browse the repository at this point in the history
…#8167)

## Summary

Changes calcite-components to a dependency of the angular wrapper,
versus a peerDep and devDep.

Stencil has it as a peerDep because it is required for the user.
arcgis-web-components and us added it as a devDep so the monorepo
dependency tree would catch it.

Putting it as a dep resolves both of the above, and it prevents the user
from needing to install it on their end. It seems like lerna doesn't
bump the peerDep when versioning local packages so it falls behind,
which causes issues.

Note: we did the same thing for the react wrapper for convenience, even
before we moved it to the monorepo
  • Loading branch information
benelan authored Nov 15, 2023
1 parent ab20eb0 commit b99656d
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 27 deletions.
19 changes: 2 additions & 17 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,11 @@ The following is an outline of the steps required to use `@esri/calcite-componen

### Install the packages

Install the Angular wrapper components along with [`@esri/calcite-components`](https://www.npmjs.com/package/@esri/calcite-components):

```sh
npm install @esri/calcite-components @esri/calcite-components-angular
npm install @esri/calcite-components-angular
```

Make sure the versions of the two packages remain the same when updating your dependencies.
This package includes the compatible version of the main component library as a dependency, so no need to install `@esri/calcite-components` separately.

### Copy local assets

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"$schema": "../../../../node_modules/ng-packagr/ng-package.schema.json",
"dest": "./dist",
"allowedNonPeerDependencies": ["@esri/calcite-components"],
"lib": {
"entryFile": "src/public-api.ts"
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,11 @@
"url": "https://github.com/Esri/calcite-design-system/issues"
},
"peerDependencies": {
"@angular/common": "^16.2.0",
"@angular/core": "^16.2.0",
"@esri/calcite-components": "1.10.1-next.3"
},
"devDependencies": {
"@esri/calcite-components": "1.10.1-next.3"
"@angular/common": ">=16.0.0",
"@angular/core": ">=16.0.0"
},
"dependencies": {
"@esri/calcite-components": "1.10.1-next.3",
"tslib": "2.3.0"
},
"lerna": {
Expand Down

0 comments on commit b99656d

Please sign in to comment.