Skip to content

Commit

Permalink
Merge branch 'main' of github.com:Esri/calcite-components into astump…
Browse files Browse the repository at this point in the history
…/7175-add-font-family-fallbacks
  • Loading branch information
alisonailea committed Dec 18, 2023
2 parents 9ff17b4 + afbcb09 commit 5b4dffc
Show file tree
Hide file tree
Showing 92 changed files with 2,946 additions and 1,498 deletions.
232 changes: 132 additions & 100 deletions package-lock.json

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"util:sync-linked-package-versions": "tsx support/syncLinkedPackageVersions.ts"
},
"devDependencies": {
"@babel/preset-react": "7.22.15",
"@babel/preset-react": "7.23.3",
"@cspell/eslint-plugin": "7.3.9",
"@esri/calcite-base": "1.2.0",
"@esri/calcite-colors": "6.1.0",
Expand All @@ -43,7 +43,7 @@
"@storybook/testing-library": "0.2.2",
"@tokens-studio/sd-transforms": "0.12.1",
"@types/dedent": "0.7.2",
"@types/eslint": "8.40.2",
"@types/eslint": "8.44.8",
"@types/estree": "1.0.5",
"@types/jest": "29.5.7",
"@types/jest-axe": "3.5.9",
Expand All @@ -70,7 +70,7 @@
"cpy": "10.1.0",
"cpy-cli": "5.0.0",
"dedent": "0.7.0",
"eslint": "8.44.0",
"eslint": "8.55.0",
"eslint-config-prettier": "8.8.0",
"eslint-plugin-import": "2.27.5",
"eslint-plugin-jest": "27.6.0",
Expand All @@ -86,7 +86,7 @@
"lerna": "7.1.5",
"lint-staged": "13.2.3",
"markdownlint-cli": "0.34.0",
"postcss": "8.4.31",
"postcss": "8.4.32",
"prettier": "2.8.8",
"puppeteer": "21.5.0",
"quicktype-core": "23.0.80",
Expand Down
18 changes: 9 additions & 9 deletions packages/calcite-components-angular/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,22 +8,22 @@
"clean": "rimraf dist node_modules .turbo .angular projects/component-library/dist"
},
"dependencies": {
"@angular/animations": "17.0.5",
"@angular/common": "17.0.5",
"@angular/compiler": "17.0.5",
"@angular/core": "17.0.5",
"@angular/forms": "17.0.5",
"@angular/platform-browser": "17.0.5",
"@angular/platform-browser-dynamic": "17.0.5",
"@angular/router": "17.0.5",
"@angular/animations": "17.0.6",
"@angular/common": "17.0.6",
"@angular/compiler": "17.0.6",
"@angular/core": "17.0.6",
"@angular/forms": "17.0.6",
"@angular/platform-browser": "17.0.6",
"@angular/platform-browser-dynamic": "17.0.6",
"@angular/router": "17.0.6",
"rxjs": "7.8.1",
"tslib": "2.6.2",
"zone.js": "0.14.2"
},
"devDependencies": {
"@angular-devkit/build-angular": "17.0.5",
"@angular/cli": "17.0.5",
"@angular/compiler-cli": "17.0.5",
"@angular/compiler-cli": "17.0.6",
"ng-packagr": "17.0.2"
},
"volta": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,30 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## [2.1.0-next.10](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.1.0-next.9...@esri/calcite-components-angular@2.1.0-next.10) (2023-12-16)

__Note:__ Version bump only for package @esri/calcite-components-angular

## [2.1.0-next.9](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.1.0-next.8...@esri/calcite-components-angular@2.1.0-next.9) (2023-12-15)

__Note:__ Version bump only for package @esri/calcite-components-angular

## [2.1.0-next.8](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.1.0-next.7...@esri/calcite-components-angular@2.1.0-next.8) (2023-12-13)

__Note:__ Version bump only for package @esri/calcite-components-angular

## [2.1.0-next.7](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.1.0-next.6...@esri/calcite-components-angular@2.1.0-next.7) (2023-12-13)

__Note:__ Version bump only for package @esri/calcite-components-angular

## [2.1.0-next.6](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.1.0-next.5...@esri/calcite-components-angular@2.1.0-next.6) (2023-12-12)

__Note:__ Version bump only for package @esri/calcite-components-angular

## [2.1.0-next.5](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.1.0-next.4...@esri/calcite-components-angular@2.1.0-next.5) (2023-12-11)

__Note:__ Version bump only for package @esri/calcite-components-angular

## [2.1.0-next.4](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.1.0-next.3...@esri/calcite-components-angular@2.1.0-next.4) (2023-12-09)

__Note:__ Version bump only for package @esri/calcite-components-angular
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@esri/calcite-components-angular",
"version": "2.1.0-next.4",
"version": "2.1.0-next.10",
"sideEffects": false,
"homepage": "https://developers.arcgis.com/calcite-design-system/",
"description": "A set of Angular components that wrap Esri's Calcite Components.",
Expand All @@ -20,7 +20,7 @@
"@angular/core": ">=16.0.0"
},
"dependencies": {
"@esri/calcite-components": "^2.1.0-next.4",
"@esri/calcite-components": "^2.1.0-next.10",
"tslib": "2.6.2"
},
"lerna": {
Expand Down
24 changes: 24 additions & 0 deletions packages/calcite-components-react/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,30 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## [2.1.0-next.10](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.1.0-next.9...@esri/calcite-components-react@2.1.0-next.10) (2023-12-16)

__Note:__ Version bump only for package @esri/calcite-components-react

## [2.1.0-next.9](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.1.0-next.8...@esri/calcite-components-react@2.1.0-next.9) (2023-12-15)

__Note:__ Version bump only for package @esri/calcite-components-react

## [2.1.0-next.8](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.1.0-next.7...@esri/calcite-components-react@2.1.0-next.8) (2023-12-13)

__Note:__ Version bump only for package @esri/calcite-components-react

## [2.1.0-next.7](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.1.0-next.6...@esri/calcite-components-react@2.1.0-next.7) (2023-12-13)

__Note:__ Version bump only for package @esri/calcite-components-react

## [2.1.0-next.6](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.1.0-next.5...@esri/calcite-components-react@2.1.0-next.6) (2023-12-12)

__Note:__ Version bump only for package @esri/calcite-components-react

## [2.1.0-next.5](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.1.0-next.4...@esri/calcite-components-react@2.1.0-next.5) (2023-12-11)

__Note:__ Version bump only for package @esri/calcite-components-react

## [2.1.0-next.4](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.1.0-next.3...@esri/calcite-components-react@2.1.0-next.4) (2023-12-09)

__Note:__ Version bump only for package @esri/calcite-components-react
Expand Down
4 changes: 2 additions & 2 deletions packages/calcite-components-react/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@esri/calcite-components-react",
"sideEffects": false,
"version": "2.1.0-next.4",
"version": "2.1.0-next.10",
"homepage": "https://developers.arcgis.com/calcite-design-system/",
"description": "A set of React components that wrap calcite components",
"license": "SEE LICENSE.md",
Expand All @@ -20,7 +20,7 @@
"dist/"
],
"dependencies": {
"@esri/calcite-components": "^2.1.0-next.4"
"@esri/calcite-components": "^2.1.0-next.10"
},
"peerDependencies": {
"react": ">=16.7",
Expand Down
44 changes: 44 additions & 0 deletions packages/calcite-components/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,50 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## [2.1.0-next.10](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.1.0-next.9...@esri/calcite-components@2.1.0-next.10) (2023-12-16)

### Features

- __list-item:__ Add calciteListItemToggle event. ([#8433](https://github.com/Esri/calcite-design-system/issues/8433)) ([1d2fa04](https://github.com/Esri/calcite-design-system/commit/1d2fa0406a303f9ae45861c3006eed0b896a207b)), closes [#8434](https://github.com/Esri/calcite-design-system/issues/8434)
- __list:__ Add drag event details to `calciteListDragStart` and `calciteListDragEnd` events ([#8438](https://github.com/Esri/calcite-design-system/issues/8438)) ([e199c08](https://github.com/Esri/calcite-design-system/commit/e199c080128d339b987512454f70a3370d9bdf98)), closes [#8437](https://github.com/Esri/calcite-design-system/issues/8437)

### Bug Fixes

- __input-date-picker:__ ensure range input toggling is consistent ([#8414](https://github.com/Esri/calcite-design-system/issues/8414)) ([cd92586](https://github.com/Esri/calcite-design-system/commit/cd925869e36f63d9ba21d77ed1dc8c765bbaf30f)), closes [#6501](https://github.com/Esri/calcite-design-system/issues/6501)
- __menu-item:__ Improve keyboard navigability when `href` populated ([#8408](https://github.com/Esri/calcite-design-system/issues/8408)) ([5b44798](https://github.com/Esri/calcite-design-system/commit/5b447981efabddf2aeab961b8be826aaab5cbd9e)), closes [#8135](https://github.com/Esri/calcite-design-system/issues/8135)
- __table-cell:__ Fix background css variable ([#8439](https://github.com/Esri/calcite-design-system/issues/8439)) ([9e5c59b](https://github.com/Esri/calcite-design-system/commit/9e5c59b94f4f8291788cd9a8734b2ea47fd60329)), closes [#8380](https://github.com/Esri/calcite-design-system/issues/8380)

## [2.1.0-next.9](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.1.0-next.8...@esri/calcite-components@2.1.0-next.9) (2023-12-15)

### Bug Fixes

- __stepper:__ emits `calciteStepperItemChange` event when switched to first step ([#8422](https://github.com/Esri/calcite-design-system/issues/8422)) ([508979f](https://github.com/Esri/calcite-design-system/commit/508979f25196556af730c984929d232858623c78)), closes [#8397](https://github.com/Esri/calcite-design-system/issues/8397)

## [2.1.0-next.8](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.1.0-next.7...@esri/calcite-components@2.1.0-next.8) (2023-12-13)

### Bug Fixes

- __floating-ui:__ improve floating element performance ([#8409](https://github.com/Esri/calcite-design-system/issues/8409)) ([4d8cfb8](https://github.com/Esri/calcite-design-system/commit/4d8cfb899857960268226db5c2a47514ea20ad18)), closes [#7979](https://github.com/Esri/calcite-design-system/issues/7979) [#8214](https://github.com/Esri/calcite-design-system/issues/8214) [#8386](https://github.com/Esri/calcite-design-system/issues/8386) [#8419](https://github.com/Esri/calcite-design-system/issues/8419) [#5697](https://github.com/Esri/calcite-design-system/issues/5697) [#8001](https://github.com/Esri/calcite-design-system/issues/8001) [#8230](https://github.com/Esri/calcite-design-system/issues/8230)

## [2.1.0-next.7](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.1.0-next.6...@esri/calcite-components@2.1.0-next.7) (2023-12-13)

### Bug Fixes

- use Stencil watchers instead of global attributes util ([#8407](https://github.com/Esri/calcite-design-system/issues/8407)) ([c531d81](https://github.com/Esri/calcite-design-system/commit/c531d815477fb2a6629c875d585f465240e2e929)), closes [#8193](https://github.com/Esri/calcite-design-system/issues/8193)

## [2.1.0-next.6](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.1.0-next.5...@esri/calcite-components@2.1.0-next.6) (2023-12-12)

### Bug Fixes

- __dropdown-item:__ avoid hover/active styling when disabled ([#8398](https://github.com/Esri/calcite-design-system/issues/8398)) ([35817dc](https://github.com/Esri/calcite-design-system/commit/35817dc6a8fc6eb3dd1d3e1b267869b39d6e8d8c)), closes [#6667](https://github.com/Esri/calcite-design-system/issues/6667)
- __modal:__ ensure document overflow styles are properly restored when multiple modals are closed/removed ([#8390](https://github.com/Esri/calcite-design-system/issues/8390)) ([f2c6b09](https://github.com/Esri/calcite-design-system/commit/f2c6b0990d23e080ca665d72fb3bd05c1f3e227d)), closes [#6594](https://github.com/Esri/calcite-design-system/issues/6594)

## [2.1.0-next.5](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.1.0-next.4...@esri/calcite-components@2.1.0-next.5) (2023-12-11)

### Bug Fixes

- __tab:__ prevent vertical scrollbar on content pane when the height of outer elements are specified ([#8399](https://github.com/Esri/calcite-design-system/issues/8399)) ([9e6d901](https://github.com/Esri/calcite-design-system/commit/9e6d9013fead27aa5c816d0c21429f62c1f224af)), closes [#8139](https://github.com/Esri/calcite-design-system/issues/8139)

## [2.1.0-next.4](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.1.0-next.3...@esri/calcite-components@2.1.0-next.4) (2023-12-09)

### Bug Fixes
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,11 @@ However, you _could_ extend the native element to allow an association.

## 2. Tests

**The best tools only find 30% of known issues**, so they can't be relied upon. But they can be the first step towards accessibility.
__The best tools only find 30% of known issues__, so they can't be relied upon. But they can be the first step towards accessibility.

Calcite Components uses the [axe-core](https://github.com/dequelabs/axe-core) and [jest-axe](https://github.com/nickcolley/jest-axe) accessibility engines throughout its components. `axe-core` contains a number of best practices to help identify accessibility practices, such as ensuring every page has an h1 heading, and to help avoid "gotchas" in ARIA like where an ARIA attribute you used will get ignored. `axe-core` can mitigate over half of WCAG issues automatically. Additionally, it will return elements as "incomplete" where it's not certain, and manual review is needed.

When a new component is added, breaking changes are introduced, and/or as new functionality is added, accessibility tests must take place. **All components should have automated tests pertaining to accessibility.**
When a new component is added, breaking changes are introduced, and/or as new functionality is added, accessibility tests must take place. __All components should have automated tests pertaining to accessibility.__

### Adding a test

Expand All @@ -96,7 +96,7 @@ describe("calcite-tree", () => {
<a href="#">Child 2</a>
<calcite-tree slot="children">
<calcite-tree-item>
<a href="http://www.google.com">Grandchild 1</a>
<a href="http://www.esri.com">Grandchild 1</a>
</calcite-tree-item>
</calcite-tree>
</calcite-tree-item>
Expand Down Expand Up @@ -152,7 +152,7 @@ FAIL src/components/tree/tree.e2e.ts (23.34 s)

## 3. Storybook

We've already added the a11y add on, [storybook-addon-a11y](https://storybook.js.org/addons/@storybook/addon-a11y) which uses `axe-core`, the same accessibility engine used for automated testing in CC. As new components and enhancements are added, **ensure stories are updated to test accessibility**. This includes as properties are added to components, to ensure we're upholding high standards to fit our audience's needs.
We've already added the a11y add on, [storybook-addon-a11y](https://storybook.js.org/addons/@storybook/addon-a11y) which uses `axe-core`, the same accessibility engine used for automated testing in CC. As new components and enhancements are added, __ensure stories are updated to test accessibility__. This includes as properties are added to components, to ensure we're upholding high standards to fit our audience's needs.

[Learn more on writing stories](https://github.com/Esri/calcite-design-system/blob/main/CONTRIBUTING.md#writing-stories) from our contributing docs.

Expand Down
40 changes: 1 addition & 39 deletions packages/calcite-components/conventions/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -366,45 +366,7 @@ There are utilities for common workflows in [`src/utils`](../src/utils).

### Global attributes

The [`globalAttributes`](../src/utils/globalAttributes.ts) util was specifically made to access the `lang` global attribute when set on a Calcite component. However, it can be extended to allow additional [global attributes](https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes#list_of_global_attributes) by adding to the [`allowedGlobalAttributes`](https://github.com/Esri/calcite-design-system/blob/a33aa0df0c5bf103f91187826e6b12b8ff266d90/src/utils/globalAttributes.ts#L4-L5) array. The util is used in [`calcite-pagination`](../src/components/pagination/pagination.tsx), which you can use as a reference.

#### Usage steps

1. Import the interface and watch/unwatch methods

```js
import { GlobalAttrComponent, watchGlobalAttributes, unwatchGlobalAttributes } from "../../utils/globalAttributes";
```

2. Implement the interface

```js
export class ComponentName implements GlobalAttrComponent {
```
3. Add `globalAttributes` state
```js
@State() globalAttributes = {};
```
4. Add connect/disconnect callbacks
```js
connectedCallback(): void {
watchGlobalAttributes(this, ["lang"]);
}

disconnectedCallback(): void {
unwatchGlobalAttributes(this);
}
```
5. Use the state to access `lang` (or another global attribute that may be allowed in the future).
```js
const lang = this.globalAttributes["lang"] || document.documentElement.lang || "en";
```
Watching global attributes on components is now possible with Stencil v4. Please refer to the [documentation page](https://stenciljs.com/docs/reactive-data#watching-native-html-attributes) for more information.

### BigDecimal

Expand Down
Loading

0 comments on commit 5b4dffc

Please sign in to comment.