fix(chip): disconnect mutation observer when component is disconnecte…

…d from the DOM (#7418) **Related Issue:** #7417 ## Summary ✨🧹✨
Esri · Aug 2, 2023 · 412e5fb · 412e5fb
1 parent 217324f
commit 412e5fb
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/packages/calcite-components/src/components/chip/chip.tsx b/packages/calcite-components/src/components/chip/chip.tsx
@@ -204,7 +204,7 @@ export class Chip
     connectInteractive(this);
     connectLocalized(this);
     connectMessages(this);
-    this.setupTextContentObserver();
+    this.mutationObserver?.observe(this.el, { childList: true, subtree: true });
   }
 
   componentDidLoad(): void {
@@ -220,6 +220,7 @@ export class Chip
     disconnectInteractive(this);
     disconnectLocalized(this);
     disconnectMessages(this);
+    this.mutationObserver?.disconnect();
   }
 
   async componentWillLoad(): Promise<void> {
@@ -302,10 +303,6 @@ export class Chip
     this.hasText = this.el.textContent.trim().length > 0;
   }
 
-  private setupTextContentObserver() {
-    this.mutationObserver?.observe(this.el, { childList: true, subtree: true });
-  }
-
   private handleSlotImageChange = (event: Event): void => {
     this.hasImage = slotChangeHasAssignedElement(event);
   };