fix(value-list-item): Remove undocumented properties from the Host el…

…ement. #2059
Esri · Apr 27, 2021 · 0a8eac9 · 0a8eac9
1 parent ba46cb0
commit 0a8eac9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/components/calcite-value-list-item/calcite-value-list-item.tsx b/src/components/calcite-value-list-item/calcite-value-list-item.tsx
@@ -93,8 +93,6 @@ export class CalciteValueListItem {
 
   pickListItem: HTMLCalcitePickListItemElement = null;
 
-  guid = `calcite-value-list-item-${guid()}`;
-
   // --------------------------------------------------------------------------
   //
   //  Public Methods
@@ -198,8 +196,10 @@ export class CalciteValueListItem {
   }
 
   render(): VNode {
+    const id = this.el.id || `calcite-value-list-item-${guid()}`;
+
     return (
-      <Host data-id={this.guid}>
+      <Host id={id}>
         {this.renderHandle()}
         <calcite-pick-list-item
           description={this.description}

diff --git a/src/components/calcite-value-list/calcite-value-list.tsx b/src/components/calcite-value-list/calcite-value-list.tsx
@@ -200,6 +200,7 @@ export class CalciteValueList<
     }
 
     this.sortable = Sortable.create(this.el, {
+      dataIdAttr: "id",
       handle: `.${CSS.handle}`,
       draggable: "calcite-value-list-item",
       group: this.group,