Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: light weight merkle tree didn't forget previously inserted elements #466

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

mrain
Copy link
Contributor

@mrain mrain commented Jan 16, 2024

Description

closes: #XXXX

Now the light weight merkle tree correctly forget the previously inserted elements, and we have a test for that.
Thanks for @Ayiga who spotted it.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@mrain mrain requested review from jbearer, alxiong and Ayiga January 16, 2024 20:58
jbearer
jbearer previously approved these changes Jan 16, 2024
Copy link
Member

@jbearer jbearer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrain mrain merged commit d9716f9 into main Jan 16, 2024
4 checks passed
@mrain mrain deleted the cl/mt-fix branch January 16, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants