Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add buffer polyfill with base64url support #153

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

felipecsl
Copy link
Member

@felipecsl felipecsl commented Dec 2, 2024

Fixes: FF-3645

Motivation and Context

Add buffer fork polyfill with support for base64url encoding.
Code is here https://github.com/Eppo-exp/buffer/tree/add-base64url-support
Source: feross/buffer#314 (once this is merged, we can revert back to the main buffer repo)

Description

Make sure we polyfill buffer for browser environment and it has support for base64url.

Thanks @maya-the-mango for reporting and helping with debugging

How has this been tested?

  • Started a new next.js repo and added a dependency on "@eppo/js-client-sdk": "^3.8.0",
  • Also added resolution to this fork:
  "resolutions": {
    "@eppo/js-client-sdk-common": "git+https://github.com/eppo-exp/js-sdk-common#felipecsl--buffer-polyfill"
  }

called init and verified no errors thrown

@maya-the-mango
Copy link
Contributor

Thanks @felipecsl for quick reaction. I confirm that it solves the buffer error that I previously encountered!

@felipecsl felipecsl requested a review from petzel December 2, 2024 19:16
@felipecsl felipecsl merged commit 0c93dab into main Dec 2, 2024
8 checks passed
@felipecsl felipecsl deleted the felipecsl--buffer-polyfill branch December 2, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants