This repository has been archived by the owner on May 3, 2024. It is now read-only.
Fix domain discernment for epicbox addresses #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This resolves the localhost websockets SSL error - For some reason, our 'to_address' was not properly including our domain, nor port, and default behavior is to substitute 127.0.0.1:443 - Since websockets requires a domain name for SSL validation (not an IP), this was causing an error and hang - Following this error, 'epoll' function causes epicbox to hang indefinitely because it is called with a timeout=-1 - This commit does not resolve the timeout problem. Only the domain discernment
|
Will follow up with more information on the |
skykingisepic
approved these changes
Mar 20, 2023
|
Just a note that there is probably a cleaner way to handle this. Will investigate as we fix port discernment in future. For now, this works |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-This PR resolves the localhost websockets SSL error below:
For some reason, our 'to_address' was not properly including our domain, nor port, and default behavior is to substitute
127.0.0.1:443Since ws requires a domain name for SSL validation (not an IP), this was causing an error and subsequent unresponsive hang behavior
Following this error, 'epoll' function causes epicbox to hang indefinitely because it is called with a
timeout=-1. This commit does not resolve the timeout problem. Only domain discernment is addressed here.