Fix issues 57, 56, 48 and 39. #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary encodes of floating point values are wrong in the code base since they are encoded as lists. This makes the code crash. The mentioned issues/pull requests assumes that io_lib is going to return a certain structure however, but the only knowledge we have is that it will return an iolist(). While here, provide a test case for this kind of problem to ensure it does not re-occur.
This was referenced Apr 24, 2013
Closed
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binary encodes of floating point values are wrong in the code base
since they are encoded as lists. This makes the code crash. The mentioned
issues/pull requests assumes that io_lib is going to return a certain structure
however, but the only knowledge we have is that it will return an iolist().
While here, provide a test case for this kind of problem to ensure it does not
re-occur.