Cleanup argTypes.defaultValue Warning #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdinh8124
approved these changes
Aug 10, 2022
|
🎉 This PR is included in version 1.0.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Created this branch to cleanup some of the warnings/errors we're seeing in the console.
Type of Request
chore
Approach
argTypes.defaultValueWarningThis warning was coming from
argTypes.defaultValuebeing used in theTypographycomponent stories. Updated to use the new pattern. This got rid of the warning.ReactDOM.renderErrorWe have no control over this error. The error is being caused by Storybook. See this comment on a GitHub Issue related to the topic.
In short, we are building React 18 components. They are being rendered with the React 18 API. Storybook is built using React and is still using version 17. Storybook is rendering components as we expect and we are given the full functionality of React 18.
Pull Request Creator Checklist