Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Occultism pentacle recipes not showing #9

Closed
SupaJordy opened this issue Jun 26, 2024 · 11 comments
Closed

Occultism pentacle recipes not showing #9

SupaJordy opened this issue Jun 26, 2024 · 11 comments
Labels
Bug Something isn't working fixed in next release Fixed in the next release. If the issue this is on is closed, the fix is already released

Comments

@SupaJordy
Copy link

Modpack Version

1.2.0

Describe your issue.

Recipes that are made using Occultism pentacles are not showing in EMI and are blank in the Occultism book.

Crash Report

No response

Latest Log

No response

Have you modified the modpack?

No

User Modifications

No response

Did the issue happen in singleplayer or on a server?

Singleplayer

Discord Username

jordacus

@SupaJordy SupaJordy added the Bug Something isn't working label Jun 26, 2024
@SupaJordy
Copy link
Author

If it helps, someone has advised:

There is an update for Occultism, but it will not run on the current version of neoforge and the new version of neoforge breaks other mods. It will likely get sorted out over time, but we need to wait for Occultism.

@NielsPilgaard
Copy link
Collaborator

@klikli-dev got another one for you :D

@klikli-dev
Copy link

Thanks! I'll take a look, I think this one is not yet fixed in latest occultism

@klikli-dev
Copy link

@SupaJordy could you possibly provide screenshots of the issue? To me the recipes render both in JEI and in the occultism book (testing EMI is a bit tricky right now in the dev environment but as it uses the same code as JEI I presume it should work there too)

Maybe I am misunderstanding what is not working

@MuteTiefling
Copy link
Contributor

There's nothing to screenshot, unfortunately. Checking Emi for the recipe finds nothing.

It's like the entire recipe tab is missing

@HeatherComputer

This comment was marked as outdated.

@HeatherComputer
Copy link

HeatherComputer commented Jun 26, 2024

image
Okay, hitting R on the soul gem in EMI just does nothing at all. There's nothing noted in the logs when attempting to view it or anything like that.

This however does NOT happen in an instance that has JEI only. (removed EMI from an E10 instance to test)
image

@SupaJordy
Copy link
Author

Additionally, this is what the book looks like for pentacle recipes:

image
image
image

@klikli-dev
Copy link

klikli-dev commented Jun 27, 2024

Thanks! That is very helpful so I can try to reproduce it!

EDIT: Ok the soul gem works in the book for me, I will now try to get emi running in dev, maybe emi somehow also affects the book
EDIT2: EMI not working makes sense considering there's 45 errors at runtime. I'll fix those. The book should work, it may just need both occultism and modonomicon at latest version (as I have in my dev env currently) so maybe that resolves itself as soon as other mods can go past the neoforge breaking changes.
EDIT3: Getting somewhere!
image

klikli-dev added a commit to klikli-dev/occultism that referenced this issue Jun 27, 2024
@klikli-dev
Copy link

Thanks everyone - I pushed a fix, please test with release/v1.21-1.134.2 as soon as you can cross over into the post-breaking-changes neo versions.

EMI should be fixed, and the book worked for me without changes. If any issues remain after 1.134.2 let me know so we can get them fixed up too!

@NielsPilgaard NielsPilgaard added the fixed in next release Fixed in the next release. If the issue this is on is closed, the fix is already released label Jun 27, 2024
@MuteTiefling
Copy link
Contributor

So, I had thought this was fixed in-dev, but I've noticed one small lingering related issue.

If I check Uses for Raw Iron, I can find the Foliot Crusher recipe.
I see the recipe in the Dictionary of Spirits
However, if I try to pull up recipes for the Ritual Dummy item, nothing shows.
This seems to be the case for any of the ritual dummies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working fixed in next release Fixed in the next release. If the issue this is on is closed, the fix is already released
Projects
None yet
Development

No branches or pull requests

5 participants