Add version information to windows binaries #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The information required for stamping binaries is only available when building on Linux and macOS. Therefore, the windows binary doesn't show the version with the `version` command: ``` > engflow_auth.exe version build metadata is unavailable (build with bazel's `--stamp` flag to enable) ``` This change adds the windows batch file to collect the required information on Windows systems.
Windows is using the `::` command to start comments in batch files. This change adds this word to the check_copyright_headers binary.
ulfjack
approved these changes
Dec 4, 2024
jayconrod
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The information required for stamping binaries is only available when building
on Linux and macOS. Therefore, the windows binary doesn't show the version with
the
versioncommand:This change adds the windows batch file to collect the required information on
Windows systems.