REC-67: build release on Debian 11 #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release binaries should not require glibc from Debian 12, we can use something a little older.
|
It looks like we haven't granted permissions for the Debian 11 images to CI runners yet. EDIT: now fixed. |
ola-rozenfeld
approved these changes
Sep 8, 2024
| @@ -21,17 +21,27 @@ on: | |||
| type: string | |||
| description: Version of engflow_auth to release; must be a semver version string, starting with `v` | |||
| required: true | |||
| dry_run: | |||
| type: boolean | |||
There was a problem hiding this comment.
Warning: from my experience, boolean inputs don't work as expected in GHA: https://github.com/EngFlow/engflow/blob/dbd7172b5bf1bbce62f55ca0bab167bee42cd40c/.github/workflows/build-chromium-reclient.yml#L21
minor-fixes
approved these changes
Sep 9, 2024
|
@minor-fixes - @jayconrod is out for the next 2.5 weeks, can you help merge and get released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched to a Debian 11 worker image so that we link against a glibc with a lower version.
Disabled remote execution for the release workflow because the currently release binaries
are linked against a higher version of glibc and don't run on Debian 11. Also some things
are not wired up correctly. We can turn this back on after the next release.
Added a "dry run" mode to the release workflow so it's easier to check if things are wired up
correctly in the future.