Update libs #85
Merged
Update libs #85
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enet4
approved these changes
Apr 10, 2021
There was a problem hiding this comment.
I feel that no changes are needed. Despite ndarray 0.15 comprising a substantial amount of changes, nifti already appears to work as it is and we might not even find any ways to improve this integration.
I'm not sure how complicated it usually is to migrate from ndarray 0.14 to 0.15, but it should hopefully not be a hindrance. There is nothing else "in store" at the moment, so users can stick to nifti 0.12.1 until they migrate the rest of the project anyway.
This is great, thank you! I will release version 0.13.0 right away.
|
It is done. I also took the liberty of updating a few stale things from the readme file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With ndarray ecosystem (npy and stats) ready for 0.15, we might as well update too. I updated
pretty_assertions,nalgebra+simbaandndarray. There was no specific fix or problem with those libs. And I don't think think we should update the code related to the first three. However, maybe we could update nifti-rs to actually use some of ndarray 0.15 new features, but I don't know this library precisely enough to know where to look. Maybe the best is to wait until we do have a real task and then use what's new.I didn't update the minimum rust version because it doesn't exist in this library. It's now at Rust 1.49.
As always, if there's nothing in the near-future to change, my colleagues and me would appreciate a release with these changes.