Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less dependencies #66

Merged
merged 1 commit into from
May 18, 2020
Merged

Less dependencies #66

merged 1 commit into from
May 18, 2020

Conversation

nilgoyette
Copy link
Collaborator

@nilgoyette nilgoyette commented May 12, 2020

Remove num and some default features. Not much but a cargo build --release --features ... was 2.5s faster on my work computer.

I tried getting rid of nalgebra because it's huge, I'm not using much of it (3x3 and 4x4 matrix, inverse, eigen and SVD) and we need to update it from time to time ... but it seems like an impossible job. The best I could find was default-features = false and it's not doing much!

I'll send a nalgebra update PR soon (0.18 to 0.21), if it's ok with you. EDIT: we might as well update all dependencies...

Copy link
Owner

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are OK. 👍 Thanks!

I'm keeping a note that this may be perceived as a breaking change, since a dependency in the public API has been stripped of its default features.

@Enet4 Enet4 merged commit 1efadb0 into Enet4:master May 18, 2020
@nilgoyette nilgoyette deleted the less_deps branch June 4, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants