-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add promiscuous mode for ServerAssociation #500
Conversation
Thank you for looking into this @nickamzol! Could you write a test with this PR? You can see some examples of client/server DICOM interactions in directory |
b12d229
to
5052dab
Compare
As requested, I've added both a positive and a negative test case for the new promiscuous mode. In the positive test case, a server association with promiscuous mode enabled is established. The client requests In the negative test case, a server association with promiscuous mode disabled and |
Great @nickamzol that is exactly what we need! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks spot on, and it's well tested! 👍
I will take care of expanding this capability to dicom-storescp
. Thank you!
- add `promiscuous`, implemented by #500 - adjust documentation of other arguments
- add `promiscuous`, implemented by Enet4#500 - adjust documentation of other arguments
This PR introduces a new
promiscuous
flag field forServerAssociationOptions
to allow unknown abstract syntaxes.Fixes #477