Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[encoding] Make SpecificCharacterSet opaque #489

Merged
merged 2 commits into from
Apr 12, 2024
Merged

[encoding] Make SpecificCharacterSet opaque #489

merged 2 commits into from
Apr 12, 2024

Conversation

Enet4
Copy link
Owner

@Enet4 Enet4 commented Mar 28, 2024 •
edited
Loading

  • rename existing implementation into private type CharsetImpl
  • redefine SpecificCharacterSet as encapsulating CharsetImpl
  • change return type of TextCodec::name to Cow<'static, str>
  • update uses of SpecificCharacterSet in other places

@Enet4
[encoding] Make SpecificCharacterSet opaque
663c2aa 
- rename existing implementation
 into private type CharsetImpl
- redefine SpecificCharacterSet as encapsulating CharsetImpl
- change return type of TextCodec::name
  to Cow<'static, str>
- update uses of SpecificCharacterSet in other places
@Enet4 Enet4 added breaking change Hint that this may require a major version bump on release A-lib Area: library C-encoding Crate: dicom-encoding labels Mar 28, 2024
@Enet4 Enet4 marked this pull request as ready for review March 30, 2024 12:50
@Enet4 Enet4 added this to the DICOM-rs 0.7 milestone Apr 8, 2024
@Enet4
[encoding] Improve documentation of text module
00438bc 
- add table of support
  instead of referring to SpecificCharacterSet as an enum
@Enet4 Enet4 force-pushed the change/encoding/specific-character-set-opaque branch from 88755f9 to 00438bc Compare April 12, 2024 07:42
@Enet4 Enet4 merged commit 6e6f87a into master Apr 12, 2024
4 checks passed
@Enet4 Enet4 mentioned this pull request Apr 13, 2024
Draft
@Enet4 Enet4 deleted the change/encoding/specific-character-set-opaque branch November 18, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-lib Area: library breaking change Hint that this may require a major version bump on release C-encoding Crate: dicom-encoding
Projects
None yet
Milestone
DICOM-rs 0.7
Development

Successfully merging this pull request may close these issues.
1 participant
@Enet4