Option to display calculated attack bonus in auto power cards #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added strings for new setting and string for "tier".
- Worked out how to use getAttackBonus rather than the huge mess I was making so far. - Removed the descriptive text formula translator. I like the idea but the text clutters up the tooltip too much, so it just became a needless complication.
Must update more aggressively before I start work on something!
|
Look all good to me right after some light testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new option for how the "attack" line should be displayed on auto-generated power cards. A new client-scoped setting lets you pick between:
In both cases, attacks with no ability mod will display the calculated attack bonus as before, but now will also display the formula (with substituted values) in the tooltip.
To get the attack bonus before sending the card, I added a call to getAttackBonus() in the item's roll() function, which is then passed to prepareCardData() as an extra (optional) parameter. I've made the same edit to the actor sheet's function for toggling power details.
This seems to be working smoothly, but there may be corner cases that were not obvious to me. Please double-check me before accepting!