Fix actor sheet effects tab for v11 ActiveEffects transfer #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I realised that the new v11 ActiveEffect transfer method (legacyTransferral = false) no longer "transfers" effects. Item effects don't get copied to the actor anymore, which breaks the char sheet effects tab. See also here: foundryvtt/foundryvtt#8978 The Actor4e.getActiveEffects() method returns all effects stored in the actor or transferred from items.
|
This is now using the built-in ActiveEffects getter. |
Char sheet fixes for making things work with v11 effect transfer: - Display of inactive transferred effects. - The delete button on the character sheet is inactivated if an effect is transferred from an item. - Power on/off icons for effect toggling.
Embedded effects lose their source name if the item was copied and the original item becomes unavailable (for example when deleted from the Foundry items tab). This commit changes the source name from "Unknown" to the embedding item's name.
|
I changed a few things in the actor sheet to make things more intuitive with the v11 ActiveEffect transfer:
|
The update method modified the actor persistently.
|
Had some error messages when accessing actors in a locked compendium. Turned out that the new (and awesome) default second wind effect function tried to modify the actor persistently. |
Add tooltips to the character sheet effects tab to make long labels more readable.
|
Sorry for the delay on the pull on this one. Turns out I need to actually update my Foundry software for bug fixes to actually work. My averment was still on , as I was still on v11.313, I was trying to trouble shoot the issue that was fixed in v11.314. |
|
No worries at all! Thx for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realised that the new v11 ActiveEffect transfer method (legacyTransferral = false) no longer "transfers" effects. Item effects don't get copied to the actor anymore, which breaks the char sheet effects tab. See also here: foundryvtt/foundryvtt#8978
The Actor4e.getActiveEffects() method returns all effects stored in the actor or transferred from items.