Status Conditions for Active Effects #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated "contains" helper to also search arrays of objects for a give key/value pair.
I've added a subsection so users can attach one or more status conditions to an active effect. This means we can have status conditions being applied automatically by powers, and taking advantage of durations like EoT, save-ends, etc. Since conditions can be remapped by some modules, unrecognised condition IDs are retained but labelled as "unknown". If the condition map is changed back to something that includes the ID, it should be recognised again.
- New strings for effect config updates - Restored some strings that were removed from the en.json language file. (Sorry, I had a weird input bug going on last week and I missed a few of the problems it caused!)
- New strings for effect config updates - Restored some strings that were removed from the en.json language file. (Sorry, I had a weird input bug going on last week and I missed a few of the problems it caused!)
Prevents an issue I noticed where the copy buttons can fail if the form hasn't re-rendered since you picked the status effect.
Added a div container to the target and hit prediction output. It's is effectively invisible in core, but makes styling the output a lot easier!
Added variables for the "good" and "bad" text highlights (used for hit evaluation, ongoing damage etc) and changed the applied styles to use those instead of setting hard values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Sorry for another PR so soon! I wasn't expecting to finish this quickly, but things went relatively smoothly so now I'm hoping to slip it in before you update some of these files yourself, and wind up needing to do manual merging ^_^; )
Anyway, I've added a subsection to Active Effects so users can attach one or more status conditions to them! This means we can have status conditions being applied automatically by powers, taking advantage of durations like EoT/save-ends, and being saved against automatically! :D