Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to chat card generation for NPC powers #256

Merged
merged 1 commit into from
Feb 4, 2023

Conversation

FoxLee
Copy link
Collaborator

@FoxLee FoxLee commented Dec 27, 2022

Added logic to bypass the use of description as flavour text if the power came from an NPC and has auto-generate turned on. (Also incidentally bypasses the out put of "required materials", which could be changed, but shouldn't be an issue for 4e powers anyway?)

My reasoning is that NPC powers almost never have flavour text, so relying on the "Chat Message Flavour" field to override the description text doesn't make as much sense as it does for character powers. This is largely based on the behaviour of Wigs' importer, which places the full power writeup in the description. When setting up powers I have found it useful to keep that for reference, but I use auto-generated power cards as a rule, which would cause lots of duplicate info unless you also add chat flavour. With character powers that's fine, but for NPC powers you need to either delete the description, or put some kind of placeholder in the flavour field.

This change seemed to me like a good way to handle it, allowing for the description field to be used arbitrarily without messing up auto-generated cards for flavour-textless powers. However, I know this is a subjective thing, and other contributors might disagree. Please feel free to discuss! I don't mean to force my preference if most people don't like it.

Added logic to bypass the use of description as flavour text /if/ the power came from an NPC /and/ has auto-generate turned on.
Also incidentally bypasses the out put of "required materials", which could be changed, but shouldn't be an issue for 4e powers anyway?
@EndlesNights EndlesNights changed the base branch from main to dev February 4, 2023 00:22
@EndlesNights EndlesNights merged commit bc6f15f into EndlesNights:dev Feb 4, 2023
@EndlesNights
Copy link
Owner

Sorry been a little slow getting updates recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants