Changes to chat card generation for NPC powers #256
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added logic to bypass the use of description as flavour text if the power came from an NPC and has auto-generate turned on. (Also incidentally bypasses the out put of "required materials", which could be changed, but shouldn't be an issue for 4e powers anyway?)
My reasoning is that NPC powers almost never have flavour text, so relying on the "Chat Message Flavour" field to override the description text doesn't make as much sense as it does for character powers. This is largely based on the behaviour of Wigs' importer, which places the full power writeup in the description. When setting up powers I have found it useful to keep that for reference, but I use auto-generated power cards as a rule, which would cause lots of duplicate info unless you also add chat flavour. With character powers that's fine, but for NPC powers you need to either delete the description, or put some kind of placeholder in the flavour field.
This change seemed to me like a good way to handle it, allowing for the description field to be used arbitrarily without messing up auto-generated cards for flavour-textless powers. However, I know this is a subjective thing, and other contributors might disagree. Please feel free to discuss! I don't mean to force my preference if most people don't like it.