Migration Fix and Template Changes #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migration null pointed for me on line 263 as the check was using lazy or instead of lazy and, so evaluated the 2nd statement even if the first failed and hit a null. Template changes to support Fox Lee's new mosnter sheet: -Players and monsters gain a "conditionImmunities" list. Initially this will be a list of string primarily used by the new monster sheet for monsters that are flat out immune to certain conditions. A list rather than single string to make any form of automation easier at a later date. -Monsters get details.equipment, default empty string. Humanoid monster statblocks usually include a quick equipment list for loot / descriptive purposes. This is much easier to keep as a basic string than trying to do anything clever with the actual equipment section.
…weirdass monsters get
…s had, rationalised the untyped stuff to its own object with resistances, immunities and vulnerabilities. This should be the last commit on this change as I ahve actually written the exporter code!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration null pointed for me on line 263 as the check was using lazy or instead of lazy and, so evaluated the 2nd statement even if the first failed and hit a null.
Template changes to support Fox Lee's new mosnter sheet: -Players and monsters gain a "conditionImmunities" list. Initially this will be a list of string primarily used by the new monster sheet for monsters that are flat out immune to certain conditions. A list rather than single string to make any form of automation easier at a later date.
-Monsters get details.equipment, default empty string. Humanoid monster statblocks usually include a quick equipment list for loot / descriptive purposes. This is much easier to keep as a basic string than trying to do anything clever with the actual equipment section.