[Bugfix] Attacking Multiple Tokens with FastForward #230
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Attacking when multiple tokens are targeted works as expected, rolling an attack for each target when not using the
fastForward
feature. However, when thefastForward
feature is used, only a single attack is made against just one of the tokens targeted.Fix
In
module/dice.js
change the behavior inperformD20RollAndCreateMessage()
whenform === null
to settingallRollsParts
equal to an Array withparts
repeated a number of times equal to the number of targets (or 1 if no targets). This fixes the issue so that an Attack will be made against each targeted token.Note that this does allow
allRollsParts
to get unnecessarily large when targeting multiple tokens while making a non-Attack d20Roll, but line 230 filters down to the one needed roll for these non-Attack rolls.