Update to effect variables #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
custom variables and attack/damage effects can now use @variables - the standard set that are used in attacks / damages. By quirk this also allows for attack/damage effects to use custom variables. attack/damage effects have to evaluate a non numerical expression to compute if its larger or not, but custom variables can just use the appended string method that @endlessnights factored in. Moved the custom variable substitution to last and did a pre check to see if there were any @variables left to improve performance - there is no need to iterate the effects on a character if there are no variables left to substitute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
custom variables and attack/damage effects can now use @variables - the standard set that are used in attacks / damages.
By quirk this also allows for attack/damage effects to use custom variables.
attack/damage effects have to evaluate a non numerical expression to compute if its larger or not, but custom variables can just use the appended string method that @EndlesNights factored in.
Moved the custom variable substitution to last and did a pre check to see if there were any @variables left to improve performance - there is no need to iterate the effects on a character if there are no variables left to substitute.