fixed roll expression highlighting to work with damage types #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… damage works again!
…lem we have! There were some edge cases that would result in a variable not getting properly highlighted, (error logged to console but invisible to user aside from highlighting falling back to the basic version).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Foundry term parser does not like dice flavours that appear inside brackets:
e.g. ((1d6 + 10)[Fire])
The [fire] part would be ignored. This was unfortunate as I surrounded each term in brackets to make them easier for me to hightlight. Awkward.
Put some more complicated check in for the bracket calculations such that it spots if a term is
(EXPRESSION)[FLAVOUR]and does not surrounded it with brackets, since it handily has some already for us.