Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are rituals broken, or is this unique to me? #259

Closed
drywallmud opened this issue Feb 1, 2023 · 6 comments
Closed

Are rituals broken, or is this unique to me? #259

drywallmud opened this issue Feb 1, 2023 · 6 comments

Comments

@drywallmud
Copy link

I can always manually roll rituals, but if I'm doing something wrong, I'd love to know what:

image

Also, thanks again to everyone for this amazing 4e system and the supporting modules. This continues to amaze.

@FoxLee
Copy link
Collaborator

FoxLee commented Feb 1, 2023

I ran some tests on this, since I was afraid I'd broken it somehow with my chat output tweaks! Using the Cure Disease ritual straight from the compendium importer, I found this:

  • Out of the box, it has no skill and no formula set, and rolling it throws an error.
  • Entering the formula you have there makes it roll zero values, just like your example.
  • Setting the skill only makes it work correctly.

Could you try it with no formula and see if it works then?

Further info of dev relevance: As an experiment, I entered the text used as a placeholder for the roll formula (1d20 + @attribute). This appears to roll the d20 but returns 0 for @attribute, so there's probably an issue with that variable. Using other variables on the @attr.attr.attr path seems to work as expected, but testing with a "tool" (the other place where @attribute is supposed to work) I get an "unresolved StringTerm undefined" error. Seems we need to look into how that variable is being used/parsed/defined, something's obviously got a problem.

@drywallmud
Copy link
Author

It works with no formula!

My rituals are all old (its been a while since we've gotten back into our sessions) and @Skill must have been an old value. It's difficult to know what changes with each update, and what to correct. Thanks so much for this!

@drywallmud
Copy link
Author

By the way, your styling add-on is amazing!

@FoxLee
Copy link
Collaborator

FoxLee commented Feb 2, 2023

That's great! Best to leave the Issue open probably, as it does bring up an underlying problem. But good to know there's a solution that will cover most cases.

(And you're very welcome, I'm very fond of this game so I'm always happy to contribute what I can!)

@draconas1
Copy link
Collaborator

yeah the @Skill is definitely wrong.

I've gone looking at the code, and there are some v10 bugs around managing the formula if you enter a custom formula, if you leave a blank formula it does down a different route and that still works. (which is 1d20 + modifier of the selected skill)

@EndlesNights
Copy link
Owner

Use the @attribute tag for Rituals, Thanks to draconas1 for addressing the missed v9 to v10 issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants