Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Alert): make close icon customizable via slot #1230

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Conversation

dgonzalezr
Copy link
Collaborator

Description

This pull request enables users to specify an alternative close button for the Alert component through a slot, particularly when using a custom icon library.

Related Issue

Fixes #ISSUE_NUMBER

Documentation

Screenshots (if applicable)

Checklist

  • I have read the CONTRIBUTING document.
  • I have read the CODE OF CONDUCT document.
  • I have reviewed my code.
  • I have tested the changes locally.
  • I have updated the documentation (if applicable).
  • I have added unit tests and e2e tests (if applicable).
  • I have requested reviews from relevant team members.

Additional Notes

@dgonzalezr dgonzalezr added the bug 🐛 Something isn't working label Aug 27, 2024
endv-bogdanb
endv-bogdanb previously approved these changes Aug 27, 2024
Cata1989
Cata1989 previously approved these changes Aug 27, 2024
Copy link
Collaborator

@Cata1989 Cata1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dgonzalezr dgonzalezr dismissed stale reviews from Cata1989 and endv-bogdanb via f3ae581 August 27, 2024 08:51
Copy link

@dgonzalezr dgonzalezr merged commit 97bae5f into main Aug 27, 2024
6 checks passed
@dgonzalezr dgonzalezr deleted the fix/alert branch August 27, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants