Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Drawer): deprecate placement and add position property #1110

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

dgonzalezr
Copy link
Collaborator

@dgonzalezr dgonzalezr commented Jun 14, 2024

Description

We have moved from physical CSS properties to logical properties and to align with that we are deprecating the placement property in favor of the position prop with start | end values.

With placement we were using right and left values which are no longer applicable in the context of using CSS logical properties.

Related Issue

Fixes #ISSUE_NUMBER

Documentation

Screenshots (if applicable)

Checklist

  • I have read the CONTRIBUTING document.
  • I have read the CODE OF CONDUCT document.
  • I have reviewed my own code.
  • I have tested the changes locally.
  • I have updated the documentation (if applicable).
  • I have added unit tests and e2e tests (if applicable).
  • I have requested reviews from relevant team members.

Additional Notes

@dgonzalezr dgonzalezr added the feature 🛠 New feature or request label Jun 14, 2024
@dgonzalezr dgonzalezr changed the title feat(Drawer): deprecate placement and add position property feat(Drawer): deprecate placement and add position property Jun 14, 2024
Copy link

sonarqubecloud bot commented Jun 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dgonzalezr dgonzalezr merged commit 33b2214 into main Jun 14, 2024
6 checks passed
@dgonzalezr dgonzalezr deleted the refactor/drawer-deprecate-placement branch June 14, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🛠 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants