Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Slider): range thumbs being stuck when min/max values overlap #1075

Merged
merged 1 commit into from
May 30, 2024

Conversation

dgonzalezr
Copy link
Collaborator

@dgonzalezr dgonzalezr commented May 29, 2024

Description

This PR fixes the issue on the Slider range, where the thumbs get stuck if the values (min/max) are both the maximum value or the minimum value allowed. As a workaround, we change the zIndex of the min or the max input value used under the hood.

Related Issue

Fixes #1073

Documentation

Screenshots (if applicable)

CleanShot.2024-05-29.at.19.44.08.mp4

Checklist

  • I have read the CONTRIBUTING document.
  • I have read the CODE OF CONDUCT document.
  • I have reviewed my own code.
  • I have tested the changes locally.
  • I have updated the documentation (if applicable).
  • I have added unit tests and e2e tests (if applicable).
  • I have requested reviews from relevant team members.

Additional Notes

Sorry, something went wrong.

@dgonzalezr dgonzalezr added the bug 🐛 Something isn't working label May 29, 2024

Verified

This commit was signed with the committer’s verified signature.
dgonzalezr Dabiel González Ramos
…verlap
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dgonzalezr dgonzalezr merged commit 8ac403d into main May 30, 2024
6 checks passed
@dgonzalezr dgonzalezr deleted the fix/slider branch May 30, 2024 07:27
Cata1989 pushed a commit that referenced this pull request Jun 3, 2024

Verified

This commit was signed with the committer’s verified signature.
dgonzalezr Dabiel González Ramos
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: range slider thumb gets stuck at 100%
3 participants